Skip to content

Automate stable CUDA update and linter using min Python verison #148912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Automate stable CUDA update and linter using min Python verison #148912

wants to merge 10 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 10, 2025 •
edited
Loading

  1. Fixes: [BE] Automate update stable_cuda version so that we can set it when introducing new cuda version #145571 . Cuda Stable is the same cuda version that is published to pypi, also used to set Metadata section in the rest of whl scripts and tag the docker releases with latest tag.
  2. Updates min python version used in linter

@atalman atalman requested a review from a team as a code owner March 10, 2025 21:10
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148912

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit eadacdf with merge base 2a1eeae (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 10, 2025
@atalman atalman changed the title Update lint older_python_version to py 3.8 Automate stable CUDA update. Update old lint version to python 3.8 Mar 11, 2025
@atalman
Copy link
Contributor Author

atalman commented Mar 11, 2025

Please note docker failure on cuda 12.8 is not related:

[Build Official Docker Images / build (12.8, 12.8.0, 9, runtime, linux/amd64)](https://hud.pytorch.org/pr/pytorch/pytorch/148912#38594257287) ([gh](https://github.com/pytorch/pytorch/actions/runs/13797984750/job/38594257287))
Process completed with exit code 2.

malfet
malfet reviewed Mar 11, 2025
View reviewed changes
.github/scripts/generate_binary_build_matrix.py

# NOTE: Also update the CUDA sources in tools/nightly.py when changing this list
CUDA_ARCHES = ["11.8", "12.6", "12.8"]
CUDA_STABLE = "12.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that related to the changes in question?

Copy link
Contributor Author

@atalman atalman Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue: #145571 - to automate CUDA stable version update

malfet
malfet requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think that this is the intended purpose of this lint test. collect_env should work on oldest Python version possible, but perhaps its no longer useful to test it in CI (or we should just test that it works for min-supported version and forget about it)

@atalman atalman changed the title Automate stable CUDA update. Update old lint version to python 3.8 Automate stable CUDA update. Mar 11, 2025
@atalman atalman changed the title Automate stable CUDA update. Automate stable CUDA update and linter using min Python verison Mar 11, 2025
malfet
malfet approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the updates

@malfet
Copy link
Contributor

malfet commented Mar 12, 2025

@pytorchbot merge -f "Lint and relevant things are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Mar 25, 2025

@pytorchbot cherry-pick --onto release/2.7 --fixes #145571 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 25, 2025
@atalman @pytorchbot
Automate stable CUDA update and linter using min Python verison (#148912
26507ae 
)

1. Fixes: #145571 . Cuda Stable is the same cuda version that is published to pypi, also used to set Metadata section in the rest of whl scripts and tag the docker releases with latest tag.
2. Updates min python version used in linter
Pull Request resolved: #148912
Approved by: https://github.com/Skylion007, https://github.com/malfet

(cherry picked from commit 29fd875)
@pytorchbot
Copy link
Collaborator

Cherry picking #148912

The cherry pick PR is at #149981 and it is linked with issue #145571. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Mar 25, 2025
Closed
malfet pushed a commit that referenced this pull request Mar 26, 2025
@pytorchbot @atalman
Automate stable CUDA update and linter using min Python verison (#149981
464432e 
)

Automate stable CUDA update and linter using min Python verison (#148912)

1. Fixes: #145571 . Cuda Stable is the same cuda version that is published to pypi, also used to set Metadata section in the rest of whl scripts and tag the docker releases with latest tag.
2. Updates min python version used in linter
Pull Request resolved: #148912
Approved by: https://github.com/Skylion007, https://github.com/malfet

(cherry picked from commit 29fd875)

Co-authored-by: atalman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BE] Automate update stable_cuda version so that we can set it when introducing new cuda version

5 participants

@atalman @malfet @pytorchmergebot @pytorchbot @Skylion007