Skip to content

[codemod][lowrisk] Remove unused exception parameter from caffe2/aten/src/ATen/cuda/CUDABlas.cpp #149328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[codemod][lowrisk] Remove unused exception parameter from caffe2/aten/src/ATen/cuda/CUDABlas.cpp #149328

wants to merge 1 commit into from

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Mar 17, 2025 •
edited
Loading

Summary:
-Wunused-exception-parameter has identified an unused exception parameter. This diff removes it.

This:

try {
    ...
} catch (exception& e) {
    // no use of e
}

should instead be written as

} catch (exception&) {

If the code compiles, this is safe to land.

Test Plan: Sandcastle

Reviewed By: dtolnay

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 17, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149328

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 45 Pending

As of commit 1a30fa9 with merge base 224cd9f (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71290929

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 17, 2025
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

@r-barnes r-barnes added release notes: cpp release notes category topic: improvements topic category labels Mar 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71290929

@r-barnes @facebook-github-bot
[codemod][lowrisk] Remove unused exception parameter from caffe2/aten…
1a30fa9 
…/src/ATen/cuda/CUDABlas.cpp (pytorch#149328)

Summary:
Pull Request resolved: pytorch#149328

`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Test Plan: Sandcastle

Reviewed By: dtolnay

Differential Revision: D71290929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71290929

@r-barnes r-barnes closed this Mar 18, 2025
@r-barnes
Copy link
Contributor Author

@pytorchbot merge -f "Good to go"

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #149328

@izaitsevfb izaitsevfb reopened this Mar 19, 2025
@izaitsevfb
Copy link
Contributor

@pytorchbot merge -f "Good to go"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@eqy eqy eqy approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: cpp release notes category topic: improvements topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@r-barnes @facebook-github-bot @Skylion007 @pytorchmergebot @izaitsevfb @eqy