[CI][BE] Update other actions #149922
Closed
[CI][BE] Update other actions #149922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149922
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 3917bea with merge base e77ca19 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Mar 25, 2025
|
Starting merge as part of PR stack under #149919 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 25, 2025
- fix anti-pattern started by #81922 when x86 actionlint binaries were placed in Linux-arm64 folder - Fix renaming lint violations, namely ``` >>> Lint for .github/workflows/_linux-test.yml: Error (ACTIONLINT) [expression] property "workspace" is not defined in object type {arch: string; debug: string; environment: string; name: string; os: string; temp: string; tool_cache: string} 446 | if: failure() && steps.install-nvidia-driver.outcome && steps.install-nvidia-driver.outcome != 'skipped' 447 | shell: bash 448 | env: >>> 449 | RUNNER_WORKSPACE: ${{ runner.workspace }} 450 | run: | 451 | set +e 452 | set -x >>> Lint for .github/workflows/create_release.yml: Error (ACTIONLINT) [deprecated-commands] workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using- workflows/workflow-commands-for-github-actions 80 | path: ${{ env.PT_RELEASE_FILE }} 81 | - name: Set output 82 | id: release_name >>> 83 | run: echo "::set-output name=pt_release_name::${{ env.PT_RELEASE_NAME }}.tar.gz" 84 | 85 | upload_source_code_to_s3: 86 | if: ${{ github.repository == 'pytorch/pytorch' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && contains(github.ref, 'rc') }} >>> Lint for .github/workflows/target-determination-indexer.yml: Error (ACTIONLINT) [shellcheck] shellcheck reported issue in this script: SC2086:info:3:3: Double quote to prevent globbing and word splitting 98 | DOCKER_IMAGE: ${{ steps.calculate-docker-image.outputs.docker-image }} 99 | GITHUB_RUN_ID: ${{ github.run_id }} 100 | AWS_DEFAULT_REGION: us-east-1 >>> 101 | run: | 102 | # detached container should get cleaned up by teardown_ec2_linux 103 | container_name=$(docker run \ 104 | ${GPU_FLAG:-} \ ``` Pull Request resolved: #149919 Approved by: https://github.com/jeanschmidt, https://github.com/atalman, https://github.com/Skylion007 ghstack dependencies: #149917, #149918, #149922
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Discovered by actionlint-1.7.7: - `actions/checkout@v3`->`actions/checkout@v4` - `actions/setup-python@v4` -> `actions/setup-python@v5` Pull Request resolved: pytorch#149922 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#149917, pytorch#149918
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
- fix anti-pattern started by pytorch#81922 when x86 actionlint binaries were placed in Linux-arm64 folder - Fix renaming lint violations, namely ``` >>> Lint for .github/workflows/_linux-test.yml: Error (ACTIONLINT) [expression] property "workspace" is not defined in object type {arch: string; debug: string; environment: string; name: string; os: string; temp: string; tool_cache: string} 446 | if: failure() && steps.install-nvidia-driver.outcome && steps.install-nvidia-driver.outcome != 'skipped' 447 | shell: bash 448 | env: >>> 449 | RUNNER_WORKSPACE: ${{ runner.workspace }} 450 | run: | 451 | set +e 452 | set -x >>> Lint for .github/workflows/create_release.yml: Error (ACTIONLINT) [deprecated-commands] workflow command "set-output" was deprecated. use `echo "{name}={value}" >> $GITHUB_OUTPUT` instead: https://docs.github.com/en/actions/using- workflows/workflow-commands-for-github-actions 80 | path: ${{ env.PT_RELEASE_FILE }} 81 | - name: Set output 82 | id: release_name >>> 83 | run: echo "::set-output name=pt_release_name::${{ env.PT_RELEASE_NAME }}.tar.gz" 84 | 85 | upload_source_code_to_s3: 86 | if: ${{ github.repository == 'pytorch/pytorch' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && contains(github.ref, 'rc') }} >>> Lint for .github/workflows/target-determination-indexer.yml: Error (ACTIONLINT) [shellcheck] shellcheck reported issue in this script: SC2086:info:3:3: Double quote to prevent globbing and word splitting 98 | DOCKER_IMAGE: ${{ steps.calculate-docker-image.outputs.docker-image }} 99 | GITHUB_RUN_ID: ${{ github.run_id }} 100 | AWS_DEFAULT_REGION: us-east-1 >>> 101 | run: | 102 | # detached container should get cleaned up by teardown_ec2_linux 103 | container_name=$(docker run \ 104 | ${GPU_FLAG:-} \ ``` Pull Request resolved: pytorch#149919 Approved by: https://github.com/jeanschmidt, https://github.com/atalman, https://github.com/Skylion007 ghstack dependencies: pytorch#149917, pytorch#149918, pytorch#149922
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
Discovered by actionlint-1.7.7 ghstack-source-id: c8f7e10 Pull Request resolved: pytorch/pytorch#149922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Discovered by actionlint-1.7.7:
actions/checkout@v3->actions/checkout@v4actions/setup-python@v4->actions/setup-python@v5