Skip to content

[CUDA][CUTLASS] CUTLASS 3.9 submodule upgrade #151253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[CUDA][CUTLASS] CUTLASS 3.9 submodule upgrade #151253

wants to merge 6 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Apr 14, 2025 •
edited by pytorch-bot bot
Loading

Originally authored by Jack Kosaian, likely needs #ifdefs if we want to preserve compat with 3.8

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @ptrblck @msaroufim @jerryzh168

@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category labels Apr 14, 2025
@eqy eqy requested a review from nWEIdia April 14, 2025 18:55
@eqy eqy requested a review from syed-ahmed as a code owner April 14, 2025 18:55
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151253

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2656eb6 with merge base 982062d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Apr 14, 2025
@eqy eqy added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 14, 2025
Skylion007
Skylion007 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to do this. <3

@eqy eqy mentioned this pull request Apr 18, 2025
Closed
@henrylhtsang henrylhtsang requested a review from drisspg April 18, 2025 23:26
@eqy eqy changed the title [WIP][CUDA][CUTLASS] CUTLASS 3.9 upgrade [CUDA][CUTLASS] CUTLASS 3.9 upgrade Apr 19, 2025
@eqy eqy assigned henrylhtsang and unassigned henrylhtsang Apr 19, 2025
@eqy eqy requested a review from henrylhtsang April 19, 2025 00:06
@Skylion007
Copy link
Collaborator

Skylion007 commented Apr 19, 2025 •
edited
Loading

@eqy since CUTLASS isn't pinned yet, can we fix the curr_stride bugs upstream? Issue opened: NVIDIA/cutlass#2253

@drisspg
Copy link
Contributor

drisspg commented Apr 21, 2025

cc @henrylhtsang since you already have some internal patches

@henrylhtsang
Copy link
Contributor

https://github.com/NVIDIA/cutlass/releases/tag/v3.9.0

Skylion007
Skylion007 reviewed Apr 26, 2025
View reviewed changes
@henrylhtsang
Copy link
Contributor

Let's try to land it

@eqy
Copy link
Collaborator Author

eqy commented Apr 28, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

This PR updates submodules third_party/cutlass

If those updates are intentional, please add "submodule" keyword to PR title/description.

@eqy eqy changed the title [CUDA][CUTLASS] CUTLASS 3.9 upgrade [CUDA][CUTLASS] CUTLASS 3.9 submodule upgrade Apr 28, 2025
@eqy
Copy link
Collaborator Author

eqy commented Apr 28, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@henrylhtsang henrylhtsang henrylhtsang approved these changes

@nWEIdia nWEIdia Awaiting requested review from nWEIdia

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@drisspg drisspg Awaiting requested review from drisspg

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eqy @Skylion007 @drisspg @henrylhtsang @pytorchmergebot