fix test_einsum: use initialized values #151363
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151363
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 552de5d with merge base 331423e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
topic: not user facing
|
This pull request was exported from Phabricator. Differential Revision: D73067722 |
|
This pull request was exported from Phabricator. Differential Revision: D73067722 |
ColinPeppler
force-pushed
the
export-D73067722
branch
from
0edc432 to
80a4fc8
Compare
Summary: Pull Request resolved: pytorch#151363 `empty` uses uninitialized values so that could be NaNs, thus, the assert_close kept failing in FBCode. Test Plan: ``` buck test 'fbcode//mode/opt' fbcode//caffe2/test/inductor:unbacked_symints_cpu -- --exact 'caffe2/test/inductor:unbacked_symints_cpu - test_einsum_cpu (caffe2.test.inductor.test_unbacked_symints.TestUnbackedSymintsCPU)' --env TORCH_LOGS="+output_code" --print-passing-details --env TORCH_LOGS_FORMAT="%(filename)s:%(lineno)s: %(message)s" ``` Reviewed By: YUNQIUGUO Differential Revision: D73067722
|
This pull request was exported from Phabricator. Differential Revision: D73067722 |
ColinPeppler
force-pushed
the
export-D73067722
branch
from
80a4fc8 to
552de5d
Compare
|
@pytorchbot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "to land forward fix" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: `empty` uses uninitialized values so that could be NaNs, thus, the assert_close kept failing in FBCode. Test Plan: ``` buck test 'fbcode//mode/opt' fbcode//caffe2/test/inductor:unbacked_symints_cpu -- --exact 'caffe2/test/inductor:unbacked_symints_cpu - test_einsum_cpu (caffe2.test.inductor.test_unbacked_symints.TestUnbackedSymintsCPU)' --env TORCH_LOGS="+output_code" --print-passing-details --env TORCH_LOGS_FORMAT="%(filename)s:%(lineno)s: %(message)s" ``` Differential Revision: D73067722 Pull Request resolved: pytorch#151363 Approved by: https://github.com/Camyll Co-authored-by: Camyll Harajli <camyllh@meta.com>
Summary: `empty` uses uninitialized values so that could be NaNs, thus, the assert_close kept failing in FBCode. Test Plan: ``` buck test 'fbcode//mode/opt' fbcode//caffe2/test/inductor:unbacked_symints_cpu -- --exact 'caffe2/test/inductor:unbacked_symints_cpu - test_einsum_cpu (caffe2.test.inductor.test_unbacked_symints.TestUnbackedSymintsCPU)' --env TORCH_LOGS="+output_code" --print-passing-details --env TORCH_LOGS_FORMAT="%(filename)s:%(lineno)s: %(message)s" ``` Differential Revision: D73067722 Pull Request resolved: pytorch#151363 Approved by: https://github.com/Camyll Co-authored-by: Camyll Harajli <camyllh@meta.com>
4 participants
Summary:
emptyuses uninitialized values so that could be NaNs, thus, the assert_close kept failing in FBCode.Differential Revision: D73067722
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov