Skip to content

Conversation

@shink
Copy link
Contributor

@shink shink commented Apr 25, 2025

Changes

Replace Union[SymInt, int] and Union[int, SymInt] with IntLikeType.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152157

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5c7a661 with merge base 1a6d50d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Apr 25, 2025
@shink shink force-pushed the fix/types/intliketype branch from ea240ca to d885d4f Compare April 25, 2025 02:36
@shink shink changed the title [Typing] Enable torch.types.IntLikeType [Typing] Enable torch.types.IntLikeType/FloatLikeType/BoolLikeType Apr 25, 2025
@shink shink changed the title [Typing] Enable torch.types.IntLikeType/FloatLikeType/BoolLikeType [Typing] Enable torch.types.IntLikeType / FloatLikeType / BoolLikeType Apr 25, 2025
@Skylion007 Skylion007 added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Apr 25, 2025
@shink
Copy link
Contributor Author

shink commented Apr 25, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 25, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged open source release notes: fx release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants