Skip to content

Use std::apply for CPU code #152526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use std::apply for CPU code #152526

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Apr 30, 2025 •
edited
Loading

The supported compilers are recent enough to enable std::apply in C++17.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152526

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a87b0f with merge base e9d42b3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Apr 30, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Apr 30, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 30, 2025
@cyyever cyyever force-pushed the std_apply branch 2 times, most recently from 32bd3f9 to a66409a Compare April 30, 2025 10:06
Skylion007
Skylion007 reviewed Apr 30, 2025
View reviewed changes
@cyyever cyyever requested review from eqy and syed-ahmed as code owners April 30, 2025 13:25
@cyyever cyyever force-pushed the std_apply branch 2 times, most recently from 7fb8f32 to dbc9010 Compare April 30, 2025 14:10
@HDCharles HDCharles added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented May 11, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased std_apply onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout std_apply && git pull --rebase)

@cyyever cyyever requested a review from ezyang June 27, 2025 06:31
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 27, 2025

@pytorchbot rebase

@cyyever cyyever added the ciflow/rocm Trigger "default" config CI on ROCm label Jun 27, 2025
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased std_apply onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout std_apply && git pull --rebase)

@github-actions github-actions bot added the Stale label Aug 26, 2025
@pytorch pytorch deleted a comment from github-actions bot Aug 26, 2025
@cyyever cyyever requested a review from Skylion007 August 26, 2025 11:35
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 26, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased std_apply onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout std_apply && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 28, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@cyyever @markc-614
Use std::apply for CPU code (pytorch#152526)
0359620 
The supported compilers are recent enough to enable std::apply in C++17.

Pull Request resolved: pytorch#152526
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the std_apply branch September 28, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyyever @pytorchmergebot @ezyang @Skylion007 @pytorchbot @HDCharles