[Dynamo] Fix typing in graph_deduplication.py #152572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mlazos wants to merge 8 commits into gh/mlazos/43/base from gh/mlazos/43/head

Contributor

mlazos commented May 1, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames


          [Dynamo] Fix typing in graph_deduplication.py

2da34c3

[ghstack-poisoned]

This was referenced May 1, 2025

[Hierarchical Compilation] Track node mutations #152389

Closed

[Hierarchical Compilation] Use universal flatten APIs #152505

Closed

[Hierarchical Compile] Add mutation dependencies to topological sorting #152410

Closed

pytorch-bot bot commented May 1, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152572

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit da6fa0c with merge base 9785b32 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh) (trunk failure)
MISSING REGRESSION TEST

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (#152916)
[ FAILED ] AotInductorTest.BasicTestCpu

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced May 1, 2025

[Hierarchical Compile] Take into account mutation deps in cycle detection #152506

Closed

[Hierarchical Compile] Replace tracing alias and mutation check with dynamo impl #152570

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels

mlazos added a commit that referenced this pull request


          [Dynamo] Fix typing in graph_deduplication.py

48e4894

ghstack-source-id: 3e24744
Pull Request resolved: #152572

mlazos added the topic: not user facing label

mlazos mentioned this pull request

[Dynamo] Optimize dedupe region ancestor tracking #152589

Closed

Skylion007 approved these changes

View reviewed changes

anijain2305 approved these changes

View reviewed changes


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

1266ca5

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 7, 2025

Starting merge as part of PR stack under #152589


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

fbe2f3f

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 8, 2025

Starting merge as part of PR stack under #152589

4 similar comments

Collaborator

pytorchmergebot commented May 8, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 8, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 8, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

2471cfe

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589

3 similar comments

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 9, 2025

Starting merge as part of PR stack under #152589

3 similar comments

Collaborator

pytorchmergebot commented May 10, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 10, 2025

Starting merge as part of PR stack under #152589

Collaborator

pytorchmergebot commented May 10, 2025

Starting merge as part of PR stack under #152589

pytorchmergebot closed this in

15166be

pytorchmergebot pushed a commit that referenced this pull request


          [Dynamo] Optimize dedupe region ancestor tracking (#152589)

b5f1345

Pull Request resolved: #152589
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410, #152506, #152570, #152572

pytorchmergebot added the Merged label

pytorchmergebot added a commit that referenced this pull request


          Revert "[Dynamo] Fix typing in graph_deduplication.py (#152572)"

0071fda

This reverts commit 15166be.

Reverted #152572 on behalf of https://github.com/jeanschmidt due to Breaking internal signal citadel-fbcode-test-mode-opt-for-pt2_stack_for_internal-linux-0 please see diff [D74531503](https://www.internalfb.com/diff/D74531503) for more details ([comment](#152410 (comment)))

Collaborator

pytorchmergebot commented May 12, 2025

@mlazos your PR has been successfully reverted.

pytorchmergebot added Reverted ci-no-td labels

pytorchmergebot reopened this

Collaborator

pytorchmergebot commented May 12, 2025

Starting merge as part of PR stack under #152589


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

a8b23ad

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 12, 2025

Starting merge as part of PR stack under #152589


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

12c2dd6

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 12, 2025

Starting merge as part of PR stack under #152589

1 similar comment

Collaborator

pytorchmergebot commented May 13, 2025

Starting merge as part of PR stack under #152589


          Update on "[Dynamo] Fix typing in graph_deduplication.py"

da6fa0c

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Collaborator

pytorchmergebot commented May 13, 2025

Starting merge as part of PR stack under #152589

1 similar comment

Collaborator

pytorchmergebot commented May 13, 2025

Starting merge as part of PR stack under #152589

pytorchmergebot closed this in

d0faa99

pytorchmergebot pushed a commit that referenced this pull request


          [Dynamo] Optimize dedupe region ancestor tracking (#152589)

ff039d3

Pull Request resolved: #152589
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410, #152506, #152570, #152572

github-actions bot deleted the gh/mlazos/43/head branch

June 18, 2025 02:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td ciflow/inductor Merged module: dynamo Reverted topic: not user facing