-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[Ez][BE] Make implicit subpackage explicit #153613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153613
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 0c750d4 with merge base 2908c10 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_inductor/codegen/cuda/cutlass_lib_extensions and torch/ao/quantization/experimental|
looks like there are failures |
|
Thanks for review! Have fixed. |
|
@shink Please fix the Python docs for the package |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
8128475 to
e97bbf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all should be placed before imports: https://peps.python.org/pep-0008/#module-level-dunder-names
9d8ad75 to
0c750d4
Compare
| "get_weight_qspec", | ||
| "propagate_annotation", | ||
| "register_annotator", | ||
| # torch.ao.quantization.experimental.apot_utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there new entries to this file? We should not have any new entry added to this file.
Part of: #153546
Follow up: #153347
I run the following command to find all implicit namespace packages:
cc @malfet @seemethere @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov