Skip to content

Conversation

@shink
Copy link
Contributor

@shink shink commented May 15, 2025

Part of: #153546
Follow up: #153347

I run the following command to find all implicit namespace packages:

ruff check . --select INP001 | grep __init__.py

cc @malfet @seemethere @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153613

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0c750d4 with merge base 2908c10 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shink shink changed the title [Ez][BE] Make implicit subpackage explicit: torch/_inductor/codegen/cuda/cutlass_lib_extensions and torch/ao/quantization/experimental [Ez][BE] Make implicit subpackage explicit May 15, 2025
@jerryzh168
Copy link
Contributor

looks like there are failures

@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2025
@shink
Copy link
Contributor Author

shink commented May 19, 2025

Thanks for review! Have fixed.

@Skylion007
Copy link
Collaborator

@shink Please fix the Python docs for the package

@shink
Copy link
Contributor Author

shink commented May 28, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/implicit-subpackage onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/implicit-subpackage && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix/implicit-subpackage branch from 8128475 to e97bbf1 Compare May 28, 2025 01:18
@shink shink requested a review from albanD as a code owner June 3, 2025 01:53
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shink shink force-pushed the fix/implicit-subpackage branch from 9d8ad75 to 0c750d4 Compare June 9, 2025 01:55
@github-actions github-actions bot added docathon-h1-2025 module: build Build system issues module: lint Issues related to our Python/C++ lint rules (run by Travis) labels Jun 9, 2025
"get_weight_qspec",
"propagate_annotation",
"register_annotator",
# torch.ao.quantization.experimental.apot_utils
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there new entries to this file? We should not have any new entry added to this file.

@shink shink closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docathon-h1-2025 module: build Build system issues module: inductor module: lint Issues related to our Python/C++ lint rules (run by Travis) open source release notes: AO frontend release notes: quantization release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants