Skip to content

[MPS] Fix binary builds #155733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Fix binary builds #155733

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 11, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Introduced by #155611

All functions in those headers must be static and inline

@malfet
Update
f30400c 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155733

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 81 Pending, 1 Unrelated Failure

As of commit f30400c with merge base b7a73a2 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

atalman
atalman approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 11, 2025
@atalman
Copy link
Contributor

atalman commented Jun 11, 2025

lets wait for binary build to pass

@Skylion007 Skylion007 added the topic: not user facing topic category label Jun 11, 2025
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 11, 2025
@Skylion007
Copy link
Collaborator

Merge if binary builds pass

@Skylion007 Skylion007 added the ciflow/mps Run MPS tests (subset of trunk) label Jun 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Jun 11, 2025

@pytorchbot merge -f "All headers are inlined, binary builds are green again"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

thatgeeman pushed a commit to thatgeeman/pytorch-docathon that referenced this pull request Jun 15, 2025
@malfet @thatgeeman
[MPS] Fix binary builds (pytorch#155733)
a91b511 
Introduced by pytorch#155611

All functions in those headers must be static and inline
Pull Request resolved: pytorch#155733
Approved by: https://github.com/seemethere, https://github.com/atalman
@github-actions github-actions bot deleted the gh/malfet/395/head branch July 14, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @atalman @Skylion007 @pytorchmergebot @seemethere