Organize BUCK for torch/standalone #156503
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156503
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Pending, 5 Unrelated FailuresAs of commit deef972 with merge base c1ad4b8 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D76920013 |
Summary: Undo highlevel BUCKification in favor of something more organized by moving it to the dir itself Test Plan: CI Rollback Plan: Reviewed By: swolchok Differential Revision: D76920013
janeyx99
force-pushed
the
export-D76920013
branch
from
2ec6c09 to
deef972
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76920013 |
janeyx99
added
topic: build
release notes: build
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2) Details for Dev Infra teamRaised by workflow job |
|
@pytorchmergebot merge -f |
|
❌ 🤖 pytorchbot command failed: Try |
| deps = [ | ||
| ":ScalarType", | ||
| "//third_party/cpuinfo", | ||
| "//:torch_standalone_headers", |
There was a problem hiding this comment.
We don't need this one anymore?
There was a problem hiding this comment.
nope we never needed it
|
@pytorchmergebot merge -f 'changes landed internally' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Undo highlevel BUCKification in favor of something more organized by moving it to the dir itself Test Plan: CI Rollback Plan: Reviewed By: swolchok Differential Revision: D76920013 Pull Request resolved: #156503 Approved by: https://github.com/swolchok (cherry picked from commit acaf6ba)
…andalone to headeronly (#157418) * Organize BUCK for torch/standalone (#156503) Summary: Undo highlevel BUCKification in favor of something more organized by moving it to the dir itself Test Plan: CI Rollback Plan: Reviewed By: swolchok Differential Revision: D76920013 Pull Request resolved: #156503 Approved by: https://github.com/swolchok (cherry picked from commit acaf6ba) * Reapply D77381084 / #156964: Rename torch::standalone to headeronly (#157251) Was reverted due to internal failure which should be fixed now. I believe Jane wants this reapplied and picked to release, and she's out this week. Original summary: headeronly is more clear, let's change the name before anyone depends on standalone Differential Revision: [D77520173](https://our.internmc.facebook.com/intern/diff/D77520173/) Pull Request resolved: #157251 Approved by: https://github.com/janeyx99, https://github.com/Skylion007, https://github.com/desertfire (cherry picked from commit fee2377) --------- Co-authored-by: Jane Xu <janeyx@meta.com>
6 participants
Summary: Undo highlevel BUCKification in favor of something more organized by moving it to the dir itself
Test Plan:
CI
Rollback Plan:
Reviewed By: swolchok
Differential Revision: D76920013