Skip to content

Remove duplicated installation for python dependencies. #158339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove duplicated installation for python dependencies. #158339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273b414
Update
FFFrog Jul 15, 2025
649e0fa
Update
FFFrog Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,14 +294,12 @@ Install PyTorch

```bash
export CMAKE_PREFIX_PATH="${CONDA_PREFIX:-'$(dirname $(which conda))/../'}:${CMAKE_PREFIX_PATH}"
python -m pip install -r requirements-build.txt
python -m pip install --no-build-isolation -v -e .
Copy link
Contributor

@zou3519 zou3519 Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, when did we start recommending pip install -e . This might mess up users' ccache setup unless they use the CCACHE_NOHASH envvar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recent. But develop is very deprecated so we do need to make the jump.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, please forgive me if my idea is wrong.

Isn't the output path of PyTorch compilation basically fixed? Whether it is pip3 install -e . or pip install ., the output path is in lib or temp under ROOT/bulid, so the problem of cache missing caused by path fluctuation should not be a big problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has been complaining to me that vllm's build always happens in an unpredictable directory. Perhaps this is specifically a problem with their build backend, so maybe it's fine for us.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang Thanks for the explanation, so do the changes in this PR look ok?

```

**On macOS**

```bash
python -m pip install -r requirements-build.txt
python -m pip install --no-build-isolation -v -e .
```

Expand Down
Loading