Remove duplicated installation for python dependencies. #158339
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158339
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (3 Unrelated Failures)As of commit 649e0fa with merge base 9513b9d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
As the title stated. The `Common` Section have installed the python dependencies https://github.com/pytorch/pytorch/blob/1b389025ba0cc640e07991314bfba8b6ca385bd2/README.md?plain=1#L247 ghstack-source-id: 3e8e60b Pull-Request-resolved: #158339
| ```bash | ||
| export CMAKE_PREFIX_PATH="${CONDA_PREFIX:-'$(dirname $(which conda))/../'}:${CMAKE_PREFIX_PATH}" | ||
| python -m pip install -r requirements.txt | ||
| python -m pip install --no-build-isolation -v -e . |
There was a problem hiding this comment.
Oh no, when did we start recommending pip install -e . This might mess up users' ccache setup unless they use the CCACHE_NOHASH envvar.
There was a problem hiding this comment.
It is recent. But develop is very deprecated so we do need to make the jump.
There was a problem hiding this comment.
Hey, please forgive me if my idea is wrong.
Isn't the output path of PyTorch compilation basically fixed? Whether it is pip3 install -e . or pip install ., the output path is in lib or temp under ROOT/bulid, so the problem of cache missing caused by path fluctuation should not be a big problem?
There was a problem hiding this comment.
@zou3519 has been complaining to me that vllm's build always happens in an unpredictable directory. Perhaps this is specifically a problem with their build backend, so maybe it's fine for us.
There was a problem hiding this comment.
@ezyang Thanks for the explanation, so do the changes in this PR look ok?
As the title stated. The `Common` Section have installed the python dependencies https://github.com/pytorch/pytorch/blob/1b389025ba0cc640e07991314bfba8b6ca385bd2/README.md?plain=1#L247 ghstack-source-id: 4d1db50 Pull-Request-resolved: #158339
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 2, 5, linux.4xlarge.nvidia.gpu), pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), pull / linux-jammy-cuda12.8-py3.10-gcc11-sm89 / test (default, 4, 5, linux.g6.4xlarge.experimental.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As the title stated. The `Common` Section have installed the python dependencies https://github.com/pytorch/pytorch/blob/1b389025ba0cc640e07991314bfba8b6ca385bd2/README.md?plain=1#L247 Pull Request resolved: pytorch#158339 Approved by: https://github.com/ezyang
5 participants
Stack from ghstack (oldest at bottom):
As the title stated.
The
CommonSection have installed the python dependenciespytorch/README.md
Line 247 in 1b38902