Skip to content

[inductor] use writable temp file on windows #159738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[inductor] use writable temp file on windows #159738

wants to merge 10 commits into from

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Aug 3, 2025 •
edited by pytorch-bot bot
Loading

@xuhancn xuhancn added module: windows Windows support for PyTorch ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category intel This tag is for PR from Intel labels Aug 3, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159738

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit b0457d2 with merge base 7e00f2e (image):

NEW FAILURES - The following jobs have failed:

  • xpu / win-vs2022-xpu-2025_0-py3 / build (gh)
    C:\actions-runner\_work\pytorch\pytorch\build\xpu\ATen\RegisterXPU_0.cpp(6893): error C3083: 'structured_gelu_out_xpu': the symbol to the left of a '::' must be a type
  • xpu / win-vs2022-xpu-2025_1-py3 / build (gh)
    C:\actions-runner\_work\pytorch\pytorch\build\xpu\ATen\RegisterXPU_0.cpp(6893): error C3083: 'structured_gelu_out_xpu': the symbol to the left of a '::' must be a type

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn marked this pull request as ready for review August 4, 2025 02:37
@xuhancn xuhancn added the ciflow/xpu Run XPU CI tasks label Aug 4, 2025
@xuhancn xuhancn requested a review from yushangdi August 4, 2025 15:23
Skylion007
Skylion007 reviewed Aug 4, 2025
View reviewed changes
torch/_inductor/codecache.py Outdated
self.encoding = encoding
self.suffix = suffix

def __enter__(self) -> Any:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Proper Return type for Enter here. It's the tempfile object, right? Otherwise, we lose all typing info on the FileLike object

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

angelayi
angelayi approved these changes Aug 4, 2025
View reviewed changes
torch/_inductor/codecache.py
raise AssertionError(f"Unknown hash type {hash_type}")


class WritableTempFile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just code movement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to temp folder code together.

@xuhancn
Copy link
Collaborator Author

xuhancn commented Aug 4, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable), xpu / win-vs2022-xpu-2025_1-py3 / build, xpu / win-vs2022-xpu-2025_0-py3 / build, xpu / linux-jammy-xpu-2025.1-py3.9 / test (default, 2, 6, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_use_WritableTempFile_on_Windows branch August 4, 2025 22:02
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@xuhancn @markc-614
[inductor] use writable temp file on windows (pytorch#159738)
dcb8e59 
Use `WritableTempFile` on Windows, reference to: pytorch#159342

Pull Request resolved: pytorch#159738
Approved by: https://github.com/angelayi, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@angelayi angelayi angelayi approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

@gujinghui gujinghui Awaiting requested review from gujinghui

@jansel jansel Awaiting requested review from jansel

@desertfire desertfire Awaiting requested review from desertfire

@yushangdi yushangdi Awaiting requested review from yushangdi

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks intel This tag is for PR from Intel Merged module: dynamo module: inductor module: windows Windows support for PyTorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuhancn @pytorchmergebot @Skylion007 @angelayi @pytorchbot