-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Removed redundant type aliases of _device and replaced with torch.types.Device #160945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Removed redundant type aliases of _device and replaced with torch.types.Device #160945
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160945
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 923df88 with merge base 496adf9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
@pytorchbot label "topic: not user facing" |
|
Based on checks I saw, I removed the unused import and fixed the linting issue using I am not sure what I can do for Saw that issue is marked as closed, do let me know if PR is no longer required, will close it. Thanks! |
|
Thanks for cleaning this up — moving to One small note: if Appreciate the attention to detail here. Looks close to ready once the BC issue is clarified. |
|
Since the change is intentional, can bc_linter be suppressed? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 3, 3, linux.arm64.m8g.4xlarge), linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 2, 3, linux.arm64.m8g.4xlarge) Details for Dev Infra teamRaised by workflow job |
|
I merged the latest main into this branch to fix merge conflicts. @janeyx99 - Can you please try merge again |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/18792996465 |
|
@alphacrash , could you help rebase this PR? |
a1fe099 to
e7973c6
Compare
e7973c6 to
923df88
Compare
|
@EikanWang, sorry for the delay. Rebased the PR. |
Fixes Issue #152952
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @Skylion007 @janeyx99 @shink