Skip to content

[FP8][cuBLAS][SM100] cuBLAS doesn't support rowwise-scaling on sm110 or sm120 either #161236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FP8][cuBLAS][SM100] cuBLAS doesn't support rowwise-scaling on sm110 or sm120 either #161236

wants to merge 1 commit into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Aug 22, 2025 •
edited by pytorch-bot bot
Loading

@eqy eqy requested a review from syed-ahmed as a code owner August 22, 2025 02:54
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161236

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e7a4e62 with merge base af3265d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general module: cublas Problem related to cublas support open source topic: not user facing topic category module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types labels Aug 22, 2025
@Skylion007 Skylion007 requested a review from ngimel August 22, 2025 18:53
@eqy
Copy link
Collaborator Author

eqy commented Aug 25, 2025

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased eqy-patch-4 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout eqy-patch-4 && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Aug 26, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@eqy @markc-614
[FP8][cuBLAS][SM100] cuBLAS doesn't support rowwise-scaling on `sm110…
7e4914a 
…` or `sm120` either (pytorch#161236)

See also pytorch#160693

Pull Request resolved: pytorch#161236
Approved by: https://github.com/Skylion007
@github-actions github-actions bot deleted the eqy-patch-4 branch September 26, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cublas Problem related to cublas support module: cuda Related to torch.cuda, and CUDA support in general module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eqy @pytorchmergebot @Skylion007