Fix TODO in make_tensor_for_subclass_helper #162336
Conversation
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162336
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cc7ff2b with merge base 8e217a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). [ghstack-poisoned]
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). [ghstack-poisoned]
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). [ghstack-poisoned]
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). [ghstack-poisoned]
failure here is "Compiler killed by signal 9". That's SIGKILL, and I think the usual source in this context is the OOM killer? :\ |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
|
win-vs2022-cpu-py3 timed out, giving it a second chance |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). Pull Request resolved: pytorch#162336 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#162298
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). Pull Request resolved: pytorch#162336 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#162298
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though). Pull Request resolved: pytorch#162336 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#162298
3 participants
Stack from ghstack (oldest at bottom):
The constructor does accept a DataPtr (had to fix the DataPtr variant not accepting a SymInt, though).