Skip to content

Add basic tests for torch.distributed.tensor._utils.compute_global_tensor_info #162968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add basic tests for torch.distributed.tensor._utils.compute_global_tensor_info #162968

wants to merge 7 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 15, 2025 •
edited
Loading

@swolchok
Add basic tests for torch.distributed.tensor._utils.compute_global_te…
d592a95 
…nsor_info

Next PR writes a C++ implementation. Seems good to have tests first.

[ghstack-poisoned]
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Sep 15, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162968

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1c8fcfa with merge base a63221a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 15, 2025
@swolchok
Add basic tests for torch.distributed.tensor._utils.compute_global_te…
4faedb5 
…nsor_info

Next PR writes a C++ implementation. Seems good to have tests first.

ghstack-source-id: 75516de
Pull Request resolved: #162968
@swolchok swolchok mentioned this pull request Sep 15, 2025
Closed
@swolchok swolchok requested a review from ezyang September 15, 2025 19:45
@swolchok
Update on "Add basic tests for torch.distributed.tensor._utils.comput…
7d9e5ba 
…e_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Sep 15, 2025
Open
@swolchok
Update on "Add basic tests for torch.distributed.tensor._utils.comput…
391deb0 
…e_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
This was referenced Sep 16, 2025
Open
Closed
@swolchok
Update on "Add basic tests for torch.distributed.tensor._utils.comput…
0df8267 
…e_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
@swolchok
Update on "Add basic tests for torch.distributed.tensor._utils.comput…
1571c22 
…e_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
@swolchok
Update on "Add basic tests for torch.distributed.tensor._utils.comput…
125f0b2 
…e_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
@swolchok
Python 3.13 renamed _PyCFunctionFast to remove the underscore on "Add…
1c8fcfa 
… basic tests for torch.distributed.tensor._utils.compute_global_tensor_info"

Next PR writes a C++ implementation. Seems good to have tests first.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta ezyang msaroufim dcci

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@swolchok
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@swolchok swolchok mentioned this pull request Sep 23, 2025
Open
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Add basic tests for torch.distributed.tensor._utils.compute_global_te…
f899a38 
…nsor_info (pytorch#162968)

Next PR writes a C++ implementation. Seems good to have tests first.

Pull Request resolved: pytorch#162968
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#161695, pytorch#162508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@wconstab wconstab Awaiting requested review from wconstab

@wanchaol wanchaol Awaiting requested review from wanchaol

@XilunWu XilunWu Awaiting requested review from XilunWu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @pytorchmergebot @ezyang