Skip to content

Adding check for step size=0 in unfold backward to avoid divide by 0 … #162720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Adding check for step size=0 in unfold backward to avoid divide by 0 … #162720

wants to merge 5 commits into from

Conversation

@mansiag05
Copy link
Contributor

@mansiag05 mansiag05 commented Sep 11, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162720

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fb310a9 with merge base 34bb9c4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mansiag05
Copy link
Contributor Author

mansiag05 commented Sep 11, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 11, 2025
can-gaa-hou
can-gaa-hou reviewed Sep 11, 2025
View reviewed changes
@soulitzer soulitzer self-requested a review September 11, 2025 21:10
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Sep 12, 2025
can-gaa-hou
can-gaa-hou previously approved these changes Sep 17, 2025
View reviewed changes
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 18, 2025
@mansiag05
Copy link
Contributor Author

mansiag05 commented Sep 19, 2025

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2025

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@mansiag05
Copy link
Contributor Author

mansiag05 commented Sep 26, 2025

@soulitzer, could you please review the change.

@isuruf isuruf closed this Nov 3, 2025
@isuruf isuruf reopened this Nov 3, 2025
@pytorch-bot pytorch-bot bot dismissed can-gaa-hou’s stale review November 3, 2025 22:04

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@isuruf isuruf requested a review from can-gaa-hou November 3, 2025 22:04
isuruf
isuruf reviewed Nov 6, 2025
View reviewed changes
@mansiag05 mansiag05 requested a review from isuruf November 11, 2025 05:28
isuruf
isuruf reviewed Nov 13, 2025
View reviewed changes
@mansiag05 mansiag05 requested a review from isuruf November 14, 2025 07:07
@isuruf
Copy link
Collaborator

isuruf commented Nov 17, 2025

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2025

This PR needs to be approved by an authorized maintainer before merge.

@isuruf
Copy link
Collaborator

isuruf commented Nov 17, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@isuruf
Copy link
Collaborator

isuruf commented Nov 17, 2025

Can you fix the lint?

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2025
@mansiag05
Copy link
Contributor Author

mansiag05 commented Nov 20, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2025

Successfully rebased fix-issue-142462 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-issue-142462 && git pull --rebase)

@isuruf
Copy link
Collaborator

isuruf commented Nov 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 24, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Nov 25, 2025
@mansiag05 @zhudada0120
Adding check for step size=0 in unfold backward to avoid divide by 0 … (
501d411 
pytorch#162720)

…or FPE.

Fixes pytorch#142462

Pull Request resolved: pytorch#162720
Approved by: https://github.com/isuruf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isuruf isuruf isuruf approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@can-gaa-hou can-gaa-hou Awaiting requested review from can-gaa-hou

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Floating point exception (core dumped) in unfold_backward

7 participants

@mansiag05 @isuruf @pytorchmergebot @soulitzer @can-gaa-hou @pytorchbot @mikaylagawarecki