[AOTI] raise PyTorchStreamWriter open failed error code on windows #162799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhancn
added
module: windows
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162799
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d6f4d81 with merge base 75de5b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
xu_fix_PyTorchStreamWriter_open_failed_on_Windows
branch
from
2602650 to
7f8c31d
Compare
Skylion007
reviewed
Sep 12, 2025
| struct stat st; | ||
| bool dir_exists = | ||
| (stat(dir_name.c_str(), &st) == 0 && (st.st_mode & S_IFDIR)); | ||
| TORCH_CHECK( |
There was a problem hiding this comment.
We have to have a TORCH_CHECK_IO wrapper or wrapper for file not found error. Should be pretty easy to bind to exception type too
There was a problem hiding this comment.
Hi @Skylion007 these code is existing code, I just move its place to pass the failed UTs: https://github.com/pytorch/pytorch/actions/runs/17673500150/job/50232301673
There was a problem hiding this comment.
Fair, we should fix in subsequent PR
jansel
approved these changes
Sep 12, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
deleted the
xu_fix_PyTorchStreamWriter_open_failed_on_Windows
branch
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ytorch#162799) When I debug AOTI UT: `TestAOTInductorPackage_cpu::test_add`. I found it didn't output the verbose error code, when PyTorchStreamWriter open failed. This PR add the verbose error code output for debug. Local test shows as below: <img width="1124" height="653" alt="image" src="https://github.com/user-attachments/assets/01cb1a51-2982-4106-8b5b-c608ac26a075" /> The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- ``` ERROR_SHARING_VIOLATION 32 (0x20) The process cannot access the file because it is being used by another process. ``` This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: pytorch#162617 But still no idea how to open file with shared access in `std::ofstream`. I will continue to researching it. Pull Request resolved: pytorch#162799 Approved by: https://github.com/jansel
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162799) When I debug AOTI UT: `TestAOTInductorPackage_cpu::test_add`. I found it didn't output the verbose error code, when PyTorchStreamWriter open failed. This PR add the verbose error code output for debug. Local test shows as below: <img width="1124" height="653" alt="image" src="https://github.com/user-attachments/assets/01cb1a51-2982-4106-8b5b-c608ac26a075" /> The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- ``` ERROR_SHARING_VIOLATION 32 (0x20) The process cannot access the file because it is being used by another process. ``` This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: pytorch#162617 But still no idea how to open file with shared access in `std::ofstream`. I will continue to researching it. Pull Request resolved: pytorch#162799 Approved by: https://github.com/jansel
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162799) When I debug AOTI UT: `TestAOTInductorPackage_cpu::test_add`. I found it didn't output the verbose error code, when PyTorchStreamWriter open failed. This PR add the verbose error code output for debug. Local test shows as below: <img width="1124" height="653" alt="image" src="https://github.com/user-attachments/assets/01cb1a51-2982-4106-8b5b-c608ac26a075" /> The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- ``` ERROR_SHARING_VIOLATION 32 (0x20) The process cannot access the file because it is being used by another process. ``` This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: pytorch#162617 But still no idea how to open file with shared access in `std::ofstream`. I will continue to researching it. Pull Request resolved: pytorch#162799 Approved by: https://github.com/jansel
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ytorch#162799) When I debug AOTI UT: `TestAOTInductorPackage_cpu::test_add`. I found it didn't output the verbose error code, when PyTorchStreamWriter open failed. This PR add the verbose error code output for debug. Local test shows as below: <img width="1124" height="653" alt="image" src="https://github.com/user-attachments/assets/01cb1a51-2982-4106-8b5b-c608ac26a075" /> The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- ``` ERROR_SHARING_VIOLATION 32 (0x20) The process cannot access the file because it is being used by another process. ``` This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: pytorch#162617 But still no idea how to open file with shared access in `std::ofstream`. I will continue to researching it. Pull Request resolved: pytorch#162799 Approved by: https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I debug AOTI UT:
TestAOTInductorPackage_cpu::test_add. I found it didn't output the verbose error code, when PyTorchStreamWriter open failed.This PR add the verbose error code output for debug. Local test shows as below:
The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: #162617 But still no idea how to open file with shared access in
std::ofstream. I will continue to researching it.cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10