Skip to content

[BE] Delete [Ventura|Sonoma]Ops header #162921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE] Delete [Ventura|Sonoma]Ops header #162921

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 14, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Was a temp solution to make PyTorch+MPS buildable on MacOS-12, but it's no longer needed, as in 2.9+ MPS is only supported on MacOS Sonoma+

@malfet
Update
6ab73d1 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner September 14, 2025 20:55
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162921

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 30 Pending

As of commit c3ebadb with merge base 972140b (image):

NEW FAILURES - The following jobs have failed:

  • linux-binary-manywheel / manywheel-py3_14-rocm6_4-test (gh)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/var/home/pytorchci/actions-runner/_work/pytorch/pytorch/.github/actions/setup-rocm'. Did you forget to run actions/checkout before running your local action?
  • windows-binary-wheel / wheel-py3_10-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_10-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmpzDf3qc\tmpxft_0000034c_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_11-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_11-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmpR2zd9l\tmpxft_00000f1c_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_12-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_12-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmpODGKQh\tmpxft_000014cc_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_13-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_13-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmpZ6fIyo\tmpxft_00001ae0_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_13t-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_13t-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmphS3B2u\tmpxft_00001b44_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_14-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_14-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmp20baMd\tmpxft_00000e50_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned
  • windows-binary-wheel / wheel-py3_14t-cuda12_8-build (gh)
    C:/actions-runner/_work/pytorch/pytorch/pytorch/third_party/fbgemm/fbgemm_gpu/experimental/gen_ai/src/quantize/common/include\fbgemm_gpu/quantize/utils.h(19): error C3861: '__builtin_clz': identifier not found
  • windows-binary-wheel / wheel-py3_14t-cuda13_0-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\build\.tmpgkhI3g\tmpxft_0000194c_00000000-7_mx8mx8bf16_grouped_256_256_256_2_1_1.compute_100a.cudafe1.stub.c(89): error C2719: 'unnamed-parameter': formal parameter with requested alignment of 128 won't be aligned

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 14, 2025
@malfet malfet added the topic: not user facing topic category label Sep 14, 2025
@malfet malfet requested a review from Skylion007 September 14, 2025 20:56
@malfet malfet changed the title [BE] Delete VenturaOps header [BE] Delete [Ventura|Sonoma]Ops header Sep 14, 2025
@malfet malfet requested a review from dcci September 14, 2025 21:21
@malfet
Update
c3ebadb 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Sep 14, 2025
Closed
@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Sep 14, 2025
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #162925

pytorchmergebot pushed a commit that referenced this pull request Sep 15, 2025
@malfet @pytorchmergebot
[BE] Use fmt::format to define Conv key (#162925)
76e5df3 
Also use `getArrayRefString` instead of having separate cases for 2D and 3D Conv
Pull Request resolved: #162925
Approved by: https://github.com/Skylion007
ghstack dependencies: #162921
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Delete [Ventura|Sonoma]Ops header (pytorch#162921)
fa4a8d9 
Was a temp solution to make PyTorch+MPS buildable on MacOS-12, but it's no longer needed, as in 2.9+ MPS is only supported on MacOS Sonoma+
Pull Request resolved: pytorch#162921
Approved by: https://github.com/Skylion007, https://github.com/dcci
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Use fmt::format to define Conv key (pytorch#162925)
614a8f4 
Also use `getArrayRefString` instead of having separate cases for 2D and 3D Conv
Pull Request resolved: pytorch#162925
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#162921
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[BE] Delete [Ventura|Sonoma]Ops header (pytorch#162921)
13942e1 
Was a temp solution to make PyTorch+MPS buildable on MacOS-12, but it's no longer needed, as in 2.9+ MPS is only supported on MacOS Sonoma+
Pull Request resolved: pytorch#162921
Approved by: https://github.com/Skylion007, https://github.com/dcci
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[BE] Use fmt::format to define Conv key (pytorch#162925)
605cd73 
Also use `getArrayRefString` instead of having separate cases for 2D and 3D Conv
Pull Request resolved: pytorch#162925
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#162921
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[BE] Delete [Ventura|Sonoma]Ops header (pytorch#162921)
e6c5bce 
Was a temp solution to make PyTorch+MPS buildable on MacOS-12, but it's no longer needed, as in 2.9+ MPS is only supported on MacOS Sonoma+
Pull Request resolved: pytorch#162921
Approved by: https://github.com/Skylion007, https://github.com/dcci
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[BE] Use fmt::format to define Conv key (pytorch#162925)
72cdd5f 
Also use `getArrayRefString` instead of having separate cases for 2D and 3D Conv
Pull Request resolved: pytorch#162925
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#162921
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[BE] Delete [Ventura|Sonoma]Ops header (pytorch#162921)
95768a2 
Was a temp solution to make PyTorch+MPS buildable on MacOS-12, but it's no longer needed, as in 2.9+ MPS is only supported on MacOS Sonoma+
Pull Request resolved: pytorch#162921
Approved by: https://github.com/Skylion007, https://github.com/dcci
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[BE] Use fmt::format to define Conv key (pytorch#162925)
9cb7e0c 
Also use `getArrayRefString` instead of having separate cases for 2D and 3D Conv
Pull Request resolved: pytorch#162925
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#162921
@github-actions github-actions bot deleted the gh/malfet/520/head branch October 16, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@dcci dcci dcci approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @Skylion007 @dcci