-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Replace Literal[None] with None in typing #163489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163489
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 8d3ffb3 with merge base 281bb56 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
|
I also wonder what's the stance on |
|
@pytorchbot label "topic: not user facing" |
|
@vadimkantorov It is not a good time to change them because the build system still assumes Python 3.9. |
|
oh right :( though python 3.9 EOL's in roughly one month |
|
@vadimkantorov Yes, we can start the changes one or two weeks later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a ruff rule for this, don't know if it's out of preview yet
We have a ruff rule here we need to enable, but haven't yet. We can't remove all instances in the codebase because there are some tests for backward compatibility / handling of backwards compatibility. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This PR replaces Literal[None] with None in typing. Pull Request resolved: pytorch#163489 Approved by: https://github.com/Skylion007, https://github.com/mlazos
This PR replaces Literal[None] with None in typing.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben