Skip to content

Fix readibility checks in TIDY and apply them #164475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix readibility checks in TIDY and apply them #164475

wants to merge 3 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 2, 2025 •
edited by pytorch-bot bot
Loading

@cyyever
Fix clang-tidy warnings
44a0bb2 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164475

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a74a75d with merge base bac0f28 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 2, 2025
@cyyever cyyever marked this pull request as draft October 2, 2025 16:16
@cyyever
 Fix readibility checks in TIDY and apply them
e0cb879 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever changed the title Add new readibility checks to TIDY Fix readibility checks in TIDY and apply them Oct 2, 2025
@cyyever cyyever marked this pull request as ready for review October 2, 2025 16:19
albanD
albanD approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho nice catch!

Skylion007
Skylion007 reviewed Oct 2, 2025
View reviewed changes
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Oct 2, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 3, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #164475

@cyyever cyyever deleted the tidy_distribu branch October 3, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@jiayisuse jiayisuse Awaiting requested review from jiayisuse jiayisuse is a code owner

@osalpekar osalpekar Awaiting requested review from osalpekar osalpekar is a code owner

@lw lw Awaiting requested review from lw lw is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @Skylion007 @pytorchmergebot @albanD @pytorchbot