Skip to content

Enable all flake8-logging-format rules #164655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Enable all flake8-logging-format rules #164655

wants to merge 5 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 4, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 4, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164655

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 7a55415 with merge base fdab48a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2025
@janeyx99 janeyx99 requested a review from Skylion007 October 7, 2025 21:58
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 7, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the SIM105 branch October 8, 2025 00:24
@malfet
Copy link
Contributor

malfet commented Oct 8, 2025

@pytorchbot revert -m "Looks like it broke lint in trunk, see https://hud.pytorch.org/hud/pytorch/pytorch/bd3b98a8a5d68ddc84b20a4609b9ea90998bf95b/1?per_page=50&name_filter=lintrunner-noclang&mergeEphemeralLF=true" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Oct 8, 2025
@pytorchmergebot
Revert "Enable all flake8-logging-format rules (#164655)"
f713aba 
This reverts commit e98c4e8.

Reverted #164655 on behalf of https://github.com/malfet due to Looks like it broke lint in trunk, see https://hud.pytorch.org/hud/pytorch/pytorch/bd3b98a8a5d68ddc84b20a4609b9ea90998bf95b/1?per_page=50&name_filter=lintrunner-noclang&mergeEphemeralLF=true ([comment](#164655 (comment)))
@pytorchmergebot
Copy link
Collaborator

@cyyever your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 8, 2025
@cyyever cyyever restored the SIM105 branch October 8, 2025 01:10
@cyyever cyyever reopened this Oct 8, 2025
@cyyever cyyever force-pushed the SIM105 branch 5 times, most recently from 07f81dc to 257cd17 Compare October 9, 2025 10:41
@cyyever cyyever requested a review from a team as a code owner October 9, 2025 10:41
cyyever added a commit to cyyever/pytorch that referenced this pull request Oct 9, 2025
@cyyever
Reapply "Enable all flake8-logging-format rules (pytorch#164655)"
ddc7716 
This reverts commit f713aba.
cyyever added a commit to cyyever/pytorch that referenced this pull request Oct 9, 2025
@cyyever
Reapply "Enable all flake8-logging-format rules (pytorch#164655)"
abcf16a 
This reverts commit f713aba.
cyyever added a commit to cyyever/pytorch that referenced this pull request Oct 18, 2025
@cyyever
Reapply "Enable all flake8-logging-format rules (pytorch#164655)"
69db99e 
This reverts commit f713aba.
@cyyever
Use logger.exception
81c34e5 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever
Reapply "Enable all flake8-logging-format rules (pytorch#164655)"
8a8c395 
This reverts commit f713aba.
@cyyever
Use exc_info=True
23f1ffe 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever
More fixes
5908024
@cyyever
More fixes
7a55415 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2025

@pytorchmergebot merge -f "Unrelated failure on distributed tests"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the SIM105 branch October 20, 2025 01:25
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
Enable all flake8-logging-format rules (pytorch#164655)
505f077 
These rules are enabled by removing existing suppressions.
Pull Request resolved: pytorch#164655
Approved by: https://github.com/janeyx99
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@pytorchmergebot @Chao1Han
Revert "Enable all flake8-logging-format rules (pytorch#164655)"
812b8dd 
This reverts commit e98c4e8.

Reverted pytorch#164655 on behalf of https://github.com/malfet due to Looks like it broke lint in trunk, see https://hud.pytorch.org/hud/pytorch/pytorch/bd3b98a8a5d68ddc84b20a4609b9ea90998bf95b/1?per_page=50&name_filter=lintrunner-noclang&mergeEphemeralLF=true ([comment](pytorch#164655 (comment)))
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
Enable all flake8-logging-format rules (pytorch#164655)
ff9cdcd 
These rules are enabled by removing existing suppressions.

Pull Request resolved: pytorch#164655
Approved by: https://github.com/janeyx99, https://github.com/mlazos
meta-codesync bot pushed a commit to pytorch/benchmark that referenced this pull request Oct 21, 2025
@meta-codesync
Enable all flake8-logging-format rules (#164655)
af99bc5 
Summary:
These rules are enabled by removing existing suppressions.

X-link: pytorch/pytorch#164655
Approved by: https://github.com/janeyx99, https://github.com/mlazos

Reviewed By: clee2000

Differential Revision: D85010369

fbshipit-source-id: 7611bbf414b051c3ae4aae1f230c9024bca61dad
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@cyyever @zhudada0120
Enable all flake8-logging-format rules (pytorch#164655)
e93d6c7 
These rules are enabled by removing existing suppressions.

Pull Request resolved: pytorch#164655
Approved by: https://github.com/janeyx99, https://github.com/mlazos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlazos mlazos mlazos approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93 bobrenjc93 is a code owner

@laithsakka laithsakka Awaiting requested review from laithsakka laithsakka is a code owner

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@bdhirsh bdhirsh Awaiting requested review from bdhirsh bdhirsh is a code owner

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyyever @pytorchmergebot @malfet @mlazos @janeyx99 @pytorchbot