Skip to content

Fix Avoid DDE in item numel check #164934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix Avoid DDE in item numel check #164934

wants to merge 3 commits into from

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Oct 8, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

address #164725 and #164704

@laithsakka
Fix DDE in item
a43d766 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164934

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7e7328f with merge base 1fc71d1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request Oct 8, 2025
@laithsakka
Fix DDE in item
6a7d06d 
ghstack-source-id: 850a87d
Pull Request resolved: #164934
@laithsakka laithsakka mentioned this pull request Oct 8, 2025
Open
@laithsakka laithsakka added the topic: not user facing topic category label Oct 8, 2025
@laithsakka laithsakka changed the title Fix DDE in item Avoid DDE in item numel check Oct 8, 2025
laithsakka added a commit that referenced this pull request Oct 8, 2025
@laithsakka
Fix DDE in item
349adf2 
ghstack-source-id: 31ed8ac
Pull Request resolved: #164934
@laithsakka laithsakka changed the title Avoid DDE in item numel check Fix Avoid DDE in item numel check Oct 8, 2025
laithsakka added a commit that referenced this pull request Oct 8, 2025
@laithsakka
Fix DDE in item
a3543ca 
ghstack-source-id: e542c12
Pull Request resolved: #164934
ezyang
ezyang approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

aorenste
aorenste approved these changes Oct 8, 2025
View reviewed changes
aten/src/ATen/native/Scalar.cpp
Scalar item(const Tensor& self) {
auto numel = self.sym_numel();
TORCH_CHECK(numel == 1, "a Tensor with ", numel, " elements cannot be converted to Scalar");
TORCH_SYM_CHECK(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in-person (but possibly a different PR) we should comment TORCH_CHECK and TORCH_SYM_CHECK better to explain the difference.

@laithsakka
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-auto-revert
Copy link

@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert

This PR is attributed to have caused regression in:

Please investigate and fix the issues.

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@laithsakka your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 9, 2025
@pytorchmergebot
Revert "Fix Avoid DDE in item numel check (#164934)"
5209c8c 
This reverts commit a9a9a34.

Reverted #164934 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#164934 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 9, 2025
@jeanschmidt
Copy link
Contributor

@pytorchbot merge -f

Seems that autorevert should not have flagged this PR

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 9, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@jeanschmidt
Copy link
Contributor

@pytorchbot merge -f "Seems that autorevert should not have flagged this PR"

@jeanschmidt jeanschmidt added the autorevert: disable Disable autorevert for a specific PR label Oct 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt jeanschmidt mentioned this pull request Oct 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@aorenste aorenste aorenste approved these changes

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@pianpwk pianpwk Awaiting requested review from pianpwk

@ColinPeppler ColinPeppler Awaiting requested review from ColinPeppler

Assignees

No one assigned

Labels

autorevert: disable Disable autorevert for a specific PR ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@laithsakka @pytorchmergebot @jeanschmidt @ezyang @Skylion007 @aorenste