Skip to content

Reuse AcceleratorAllocatorConfig in CUDAAllocatorConfig #165135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Reuse AcceleratorAllocatorConfig in CUDAAllocatorConfig #165135

wants to merge 6 commits into from

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 10, 2025 •
edited by albanD
Loading

@guangyey guangyey mentioned this pull request Oct 10, 2025
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165135

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 670f20c with merge base ca96c67 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guangyey guangyey mentioned this pull request Oct 10, 2025
Closed
guangyey added a commit that referenced this pull request Oct 10, 2025
@guangyey
Reuse AcceleratorAllocatorConfig in CUDAAllocatorConfig
1cc4c13 
ghstack-source-id: 42c10d1
Pull Request resolved: #165135
@guangyey guangyey mentioned this pull request Oct 10, 2025
Closed
@guangyey guangyey added the topic: not user facing topic category label Oct 10, 2025
@guangyey guangyey requested a review from albanD October 10, 2025 15:59
@guangyey
Update
bf4acff 
[ghstack-poisoned]
@guangyey
Update
6fb58f7 
[ghstack-poisoned]
@guangyey
Update
cf5e468 
[ghstack-poisoned]
@guangyey
Update
4549c5f 
[ghstack-poisoned]
@guangyey guangyey mentioned this pull request Oct 13, 2025
Closed
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2025
This was referenced Oct 13, 2025
Closed
Closed
Closed
Closed
Closed
@albanD
Copy link
Collaborator

albanD commented Oct 13, 2025

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangyey
Update
a092ec7 
[ghstack-poisoned]
@guangyey
Update
670f20c 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #165281

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #165281

pytorchmergebot pushed a commit that referenced this pull request Oct 16, 2025
@guangyey @pytorchmergebot
Remove unused code in CUDAAllocatorConfig (#165136)
515b5ff 
Pull Request resolved: #165136
Approved by: https://github.com/Skylion007
ghstack dependencies: #165129, #165131, #165135
pytorchmergebot pushed a commit that referenced this pull request Oct 16, 2025
@guangyey @pytorchmergebot
Refactor CUDAAllocatorConfig using ConfigTokenizer (#165281)
219fb6a 
* #165129
Pull Request resolved: #165281
Approved by: https://github.com/albanD
ghstack dependencies: #165129, #165131, #165135, #165136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A Aidyn-A is a code owner

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guangyey @albanD @pytorchmergebot @Skylion007 @pytorchbot