Skip to content

[CUDA][cuBLAS] Only xFail addmm with reduced precision reductions on non-RTX skus #165379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CUDA][cuBLAS] Only xFail addmm with reduced precision reductions on non-RTX skus #165379

wants to merge 1 commit into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Oct 13, 2025 •
edited by pytorch-bot bot
Loading

RTX Blackwells don't behave quite like their datacenter counterparts here

cc @ptrblck @msaroufim @jerryzh168 @mruberry @csarofeen @xwang233

@eqy eqy added module: numerical-stability Problems related to numerical stability of operations module: cuda Related to torch.cuda, and CUDA support in general module: tests Issues related to tests (not the torch.testing module) module: cublas Problem related to cublas support open source topic: not user facing topic category labels Oct 13, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165379

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 9395619 with merge base f368345 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007
Skylion007 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, can we raise the tolerance just for datacenter GPUs?

@eqy
Copy link
Collaborator Author

eqy commented Oct 14, 2025

Yeah, I expect the RTX-skus to use more Ampere style kernels due to tensor core differences.

@eqy
Copy link
Collaborator Author

eqy commented Oct 16, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@eqy
Copy link
Collaborator Author

eqy commented Oct 17, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@eqy @Chao1Han
[CUDA][cuBLAS] Only xFail addmm with reduced precision reductions…
5e59c6a 
… on non-RTX skus (pytorch#165379)

RTX Blackwells don't behave quite like their datacenter counterparts here

Pull Request resolved: pytorch#165379
Approved by: https://github.com/Skylion007
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@eqy @zhudada0120
[CUDA][cuBLAS] Only xFail addmm with reduced precision reductions…
e0e058e 
… on non-RTX skus (pytorch#165379)

RTX Blackwells don't behave quite like their datacenter counterparts here

Pull Request resolved: pytorch#165379
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cublas Problem related to cublas support module: cuda Related to torch.cuda, and CUDA support in general module: numerical-stability Problems related to numerical stability of operations module: tests Issues related to tests (not the torch.testing module) open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eqy @pytorchmergebot @Skylion007