[1/N] Add strict parameter to Python zip calls #165531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
requested review from
a team,
XuehaiPan,
divyanshk,
ezyang,
fmassa,
malfet,
mruberry and
ramanishsingh
as code owners
pytorch-bot
bot
added
module: cpu
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165531
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 41d2905 with merge base b11593c ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
changed the title
cyyever
changed the title
cyyever
force-pushed
the
strict_zip
branch
4 times, most recently
from
0c87698 to
08aa9d6
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
mikaylagawarecki
added
the
triaged
Skylion007
reviewed
Oct 17, 2025
Skylion007
approved these changes
Oct 17, 2025
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3.13-clang12 / test (default, 1, 5, lf.linux.4xlarge), pull / linux-jammy-py3.13-clang12 / test (crossref, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
strict=True/Falseto zip calls in test utils.strict=Trueis passed when possible.cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168