Move static from_ivalue/to_ivalue to new shim_common.cpp #166373

mikaylagawarecki · 2025-10-28T04:52:48Z

Move from_ivalue and to_ivalue and their dependents StableIValueBoxedKernel, aoti_torch_library_impl aoti_torch_call_dispatcher into new (non-aoti shim_common.cpp)

This is in prep for the above PRs where I add v2s (torch_call_dispatcher and torch_library_impl) that are versioning aware

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-10-28T04:52:51Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166373

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

Long queue for ROCM runners, also B200 and XPU queueing is observed

✅ No Failures

As of commit 3541c2f with merge base 4295a9a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

janeyx99 · 2025-10-28T17:45:10Z

build_variables.bzl

    "torch/csrc/inductor/aoti_torch/oss_proxy_executor.cpp",
    "torch/csrc/inductor/inductor_ops.cpp",
    "torch/csrc/jit/serialization/pickle.cpp",
+    "torch/csrc/shim_common.cpp",


should this actually go in core_sources_common? or core_sources_full instead? since this doesn't have to do with inductor.

I had put it in core_sources_common previously and imported, but that caused all the mobile builds to fail

hmmmmmmmmmmmmmmmmmmmmmmmm.

i think it may be important to figure out why that is 😛 otherwise this is a bit weird why it needs to be in inductor.

I think the reason why is that this file includes the aoti shim (whose cpp file is only in the inductor sources)

So if we put this in core_sources_common, it would be included by the mobile builds (specifically this line), but then the aoti shim would be excluded

Separately, this new shim_common.cpp now implements some of aoti's shim.h, so I believe it's needed here

pytorch/caffe2/CMakeLists.txt

Lines 426 to 428 in 5e47b4d

if(USE_LITE_AOTI)

append_filelist("inductor_core_resources" LIBTORCH_CMAKE_SRCS)

endif()

Still not sure I fully understand if this is the right move, but given that it seems ok + that this is undoable, I am approving.

torch/csrc/shim_common.cpp

janeyx99

looks fine to me, barring two questions

[ghstack-poisoned]

Move `from_ivalue` and `to_ivalue` and their dependents `StableIValueBoxedKernel`, `aoti_torch_library_impl` `aoti_torch_call_dispatcher` into new (non-aoti shim_common.cpp) This is in prep for the above PRs where I add v2s (`torch_call_dispatcher` and `torch_library_impl`) that are versioning aware [ghstack-poisoned]

pytorchmergebot · 2025-10-29T15:35:33Z

Starting merge as part of PR stack under #164332

…63683) Part 1 of plan in https://docs.google.com/document/d/1MaX51H5aEQE5XnOlnZIpf9oCYwzGrTWkgBACxNzsmWE/edit?usp=sharing - Upgrade `aoti_torch_call_dispatcher` to v2 with an `extension_build_version` - Allow registration of StableIValue stack --> IValue stack adapters for schema changes #### Note: This PR does not include a linter that tells the user to add the upgrader if the schema changes, which is an important piece that will be added in a separate PR Pull Request resolved: #163683 Approved by: https://github.com/janeyx99 ghstack dependencies: #164356, #166373

1. Add `extension_build_version` and `is_internal` to `FromImpl`/`ToImpl` (this will be useful for future if we need to break the BC of any type) #163832 has the PoC of how we would actually use this system 2. Add `aoti_torch_library_impl_v2` that takes in an additional `extension_build_version` argument, updates callsite in `torch/csrc/stable/library.h` to always pass `TORCH_ABI_VERSION` for this argument 3. Add `extension_build_version` to `from_ivalue` and `to_ivalue` and update all callsites 4. Add a private `_from` and `_to` that pass `is_internal=True` to `FromImpl`/`ToImpl`, making it easier to reason about what is being called from libtorch-land / extension-land **Note: This PR does not include a linter that tells the user to update from/to if changing the ABI of a type in headeronly, which I intend to do in #163998 Pull Request resolved: #164332 Approved by: https://github.com/janeyx99 ghstack dependencies: #164356, #166373, #163683

ghstack-source-id: a8e165e Pull Request resolved: pytorch#166373

Move `from_ivalue` and `to_ivalue` and their dependents `StableIValueBoxedKernel`, `aoti_torch_library_impl` `aoti_torch_call_dispatcher` into new (non-aoti shim_common.cpp) This is in prep for the above PRs where I add v2s (`torch_call_dispatcher` and `torch_library_impl`) that are versioning aware Pull Request resolved: #166373 Approved by: https://github.com/janeyx99 ghstack dependencies: #164356

…63683) Part 1 of plan in https://docs.google.com/document/d/1MaX51H5aEQE5XnOlnZIpf9oCYwzGrTWkgBACxNzsmWE/edit?usp=sharing - Upgrade `aoti_torch_call_dispatcher` to v2 with an `extension_build_version` - Allow registration of StableIValue stack --> IValue stack adapters for schema changes #### Note: This PR does not include a linter that tells the user to add the upgrader if the schema changes, which is an important piece that will be added in a separate PR Pull Request resolved: #163683 Approved by: https://github.com/janeyx99 ghstack dependencies: #164356, #166373

1. Add `extension_build_version` and `is_internal` to `FromImpl`/`ToImpl` (this will be useful for future if we need to break the BC of any type) #163832 has the PoC of how we would actually use this system 2. Add `aoti_torch_library_impl_v2` that takes in an additional `extension_build_version` argument, updates callsite in `torch/csrc/stable/library.h` to always pass `TORCH_ABI_VERSION` for this argument 3. Add `extension_build_version` to `from_ivalue` and `to_ivalue` and update all callsites 4. Add a private `_from` and `_to` that pass `is_internal=True` to `FromImpl`/`ToImpl`, making it easier to reason about what is being called from libtorch-land / extension-land **Note: This PR does not include a linter that tells the user to update from/to if changing the ABI of a type in headeronly, which I intend to do in #163998 Pull Request resolved: #164332 Approved by: https://github.com/janeyx99 ghstack dependencies: #164356, #166373, #163683

Move static from_ivalue/to_ivalue to new shim_common.cpp

e73746b

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor release notes: inductor (aoti) labels Oct 28, 2025

mikaylagawarecki added 2 commits October 27, 2025 21:58

Update on "Move static from_ivalue/to_ivalue to new shim_common.cpp"

450bf29

[ghstack-poisoned]

Update on "Move static from_ivalue/to_ivalue to new shim_common.cpp"

1afa4c8

[ghstack-poisoned]

mikaylagawarecki requested a review from janeyx99 October 28, 2025 17:40

mikaylagawarecki marked this pull request as ready for review October 28, 2025 17:40

janeyx99 reviewed Oct 28, 2025

View reviewed changes

torch/csrc/shim_common.cpp Outdated Show resolved Hide resolved

janeyx99 reviewed Oct 28, 2025

View reviewed changes

mikaylagawarecki added 2 commits October 28, 2025 10:54

Update on "Move static from_ivalue/to_ivalue to new shim_common.cpp"

57ebce1

[ghstack-poisoned]

janeyx99 approved these changes Oct 28, 2025

View reviewed changes

mikaylagawarecki added topic: not user facing topic category and removed release notes: inductor (aoti) labels Oct 29, 2025

pytorchmergebot closed this in c0bbda3 Oct 29, 2025

pytorchmergebot added the Merged label Oct 29, 2025

mikaylagawarecki added a commit to mikaylagawarecki/pytorch that referenced this pull request Oct 29, 2025

Move static from_ivalue/to_ivalue to new shim_common.cpp

38509e6

ghstack-source-id: a8e165e Pull Request resolved: pytorch#166373

mikaylagawarecki mentioned this pull request Oct 29, 2025

Add torch::stable::Device #166579

Open

This was referenced Oct 31, 2025

Add stable::Tensor.device() #166694

Open

Redo add parallel_for to torch/csrc/stable #166695

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move static from_ivalue/to_ivalue to new shim_common.cpp #166373

Move static from_ivalue/to_ivalue to new shim_common.cpp #166373

Uh oh!

mikaylagawarecki commented Oct 28, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

janeyx99 Oct 28, 2025

Uh oh!

mikaylagawarecki Oct 28, 2025

Uh oh!

janeyx99 Oct 28, 2025

Uh oh!

mikaylagawarecki Oct 28, 2025 •

edited

Loading

Uh oh!

janeyx99 Oct 28, 2025

Uh oh!

Uh oh!

janeyx99 left a comment

Uh oh!

pytorchmergebot commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if(USE_LITE_AOTI)
	append_filelist("inductor_core_resources" LIBTORCH_CMAKE_SRCS)
	endif()

Move static from_ivalue/to_ivalue to new shim_common.cpp #166373

Move static from_ivalue/to_ivalue to new shim_common.cpp #166373

Uh oh!

Conversation

mikaylagawarecki commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166373

❗ 1 Active SEVs

✅ No Failures

Uh oh!

janeyx99 Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

janeyx99 Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janeyx99 Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mikaylagawarecki commented Oct 28, 2025 •

edited

Loading

pytorch-bot bot commented Oct 28, 2025 •

edited

Loading

mikaylagawarecki Oct 28, 2025 •

edited

Loading