Skip to content

make narrow_tensor_symint DDE-free #166379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: gh/laithsakka/317/base
Choose a base branch
from
Open

make narrow_tensor_symint DDE-free #166379

wants to merge 13 commits into from

Conversation

@laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Oct 28, 2025 •
edited
Loading

@laithsakka laithsakka mentioned this pull request Oct 28, 2025
Open
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166379

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request Oct 28, 2025
@laithsakka
make narrow_tensor_symint DDE-free
d9295b0 
ghstack-source-id: 27a84e7
Pull Request resolved: #166379
@laithsakka laithsakka added the topic: not user facing topic category label Oct 28, 2025
This was referenced Oct 28, 2025
Closed
Closed
@laithsakka laithsakka marked this pull request as draft October 28, 2025 16:27
@laithsakka laithsakka removed the request for review from ezyang October 28, 2025 17:25
@laithsakka laithsakka closed this Oct 28, 2025
@laithsakka laithsakka removed the request for review from aditvenk October 28, 2025 18:16
laithsakka added a commit that referenced this pull request Oct 29, 2025
@laithsakka
make narrow_tensor_symint DDE-free
ac89064 
ghstack-source-id: 17171a7
Pull Request resolved: #166379
@laithsakka laithsakka reopened this Oct 29, 2025
@laithsakka laithsakka marked this pull request as ready for review October 29, 2025 01:13
laithsakka added a commit that referenced this pull request Oct 29, 2025
@laithsakka
make narrow_tensor_symint DDE-free
e563f82 
ghstack-source-id: f076cad
Pull Request resolved: #166379
Lucaskabela
Lucaskabela requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@Lucaskabela Lucaskabela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have caused some odd test failures related to formatting, but otherwise the content looks good. Requesting changes for viz on the test failures

laithsakka added a commit that referenced this pull request Oct 29, 2025
@laithsakka
make narrow_tensor_symint DDE-free
dc972e5 
ghstack-source-id: 90f7ed5
Pull Request resolved: #166379
@laithsakka laithsakka mentioned this pull request Oct 29, 2025
Closed
laithsakka added a commit that referenced this pull request Oct 29, 2025
@laithsakka
make narrow_tensor_symint DDE-free
3e18f92 
ghstack-source-id: 70361c4
Pull Request resolved: #166379
@laithsakka laithsakka marked this pull request as draft October 29, 2025 16:42
laithsakka added a commit that referenced this pull request Oct 30, 2025
@laithsakka
make narrow_tensor_symint DDE-free
7ac5f4a 
ghstack-source-id: 90486a7
Pull Request resolved: #166379
@laithsakka laithsakka mentioned this pull request Oct 30, 2025
Draft
@laithsakka
Copy link
Contributor Author

laithsakka commented Oct 31, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 1, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

laithsakka added a commit that referenced this pull request Nov 1, 2025
@laithsakka
make narrow_tensor_symint DDE-free
0cbc370 
ghstack-source-id: ffc2337
Pull Request resolved: #166379
laithsakka added a commit that referenced this pull request Nov 1, 2025
@laithsakka
make narrow_tensor_symint DDE-free
37a60d7 
ghstack-source-id: 82fddc6
Pull Request resolved: #166379
@laithsakka
Copy link
Contributor Author

laithsakka commented Nov 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Nov 5, 2025

@pytorchbot revert -m "Need to revert previous PR in the stack" -c weird

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 5, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Nov 5, 2025
@pytorchmergebot
Revert "make narrow_tensor_symint DDE-free (#166379)"
53b03f1 
This reverts commit d7e2d0a.

Reverted #166379 on behalf of https://github.com/malfet due to Need to revert previous PR in the stack ([comment](#166379 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 5, 2025

@laithsakka your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 5, 2025
laithsakka added a commit that referenced this pull request Nov 5, 2025
@laithsakka
make narrow_tensor_symint DDE-free
fcbef60 
ghstack-source-id: 7f300fe
Pull Request resolved: #166379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lucaskabela Lucaskabela Lucaskabela approved these changes

@aorenste aorenste Awaiting requested review from aorenste

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@pianpwk pianpwk Awaiting requested review from pianpwk

@ezyang ezyang Awaiting requested review from ezyang ezyang is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laithsakka @pytorchmergebot @malfet @Lucaskabela