[3.14, dataloader] handle forkserver default mp start method in 3.14 #167387
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
williamwen42
requested review from
divyanshk and
ramanishsingh
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167387
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 11 PendingAs of commit f7e8d48 with merge base 3a94466 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 7, 2025
williamwen42
added
topic: not user facing
malfet
approved these changes
Nov 8, 2025
…od in 3.14" [ghstack-poisoned]
…od in 3.14" [ghstack-poisoned]
…od in 3.14" [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #167396 |
pytorchmergebot
added a commit
that referenced
this pull request
Nov 11, 2025
…in 3.14 (#167387)" This reverts commit cf63b21. Reverted #167387 on behalf of https://github.com/jeanschmidt due to merged stack seems to have introduced regressions on windows: test/test_dataloader.py::TestDataLoaderPersistentWorkers::test_worker_init_fn_forkserver [GH job link](https://github.com/pytorch/pytorch/actions/runs/19245763893/job/55023427916) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/fe0bb7cf6001532b14bba14d686baa1ff0b98de0) ([comment](#167382 (comment)))
Collaborator
|
@williamwen42 your PR has been reverted as part of the stack under #167382. |
…od in 3.14" [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):