-
Notifications
You must be signed in to change notification settings - Fork 26k
Fix aot_compile typing. #168320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aot_compile typing. #168320
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @yyetim, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
torch/_export/__init__.py
Outdated
| def aot_compile( | ||
| f: Callable, | ||
| args: tuple[Any], | ||
| args: tuple[...], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use tuple?
168761f to
5d82b7b
Compare
Summary: Any doesn't capture tuple of different number of elements. Test Plan: Unit tests Differential Revision: D87598839
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168320
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 32 Pending, 2 Unrelated FailuresAs of commit f4d81d5 with merge base 2865672 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Any doesn't capture tuple of different number of elements. Test Plan: Unit tests Differential Revision: D87598839
5d82b7b to
f4d81d5
Compare
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge failedReason: Approvers from one of the following sets are needed:
|
|
@pytorch merge -i |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-docs / build-docs-python-false, pull / linux-jammy-py3.10-gcc11 / test (docs_test, 1, 1, lf.linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
tuple[int] -> tuple[int,...] 1 -> more Like shape, shape: tuple[int, ...] # [B, Hq, M, Hkv, N, D] Inspired by #168320 Pull Request resolved: #168892 Approved by: https://github.com/cyyever, https://github.com/Skylion007
Summary: Any doesn't capture tuple of different number of elements.
Test Plan: Unit tests
Differential Revision: D87598839
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben