Skip to content

Conversation

@yyetim
Copy link
Contributor

@yyetim yyetim commented Nov 21, 2025

Summary: Any doesn't capture tuple of different number of elements.

Test Plan: Unit tests

Differential Revision: D87598839

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @yyetim, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@meta-codesync
Copy link

meta-codesync bot commented Nov 21, 2025

@yyetim has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87598839.

def aot_compile(
f: Callable,
args: tuple[Any],
args: tuple[...],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use tuple?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025
yyetim added a commit to yyetim/pytorch that referenced this pull request Nov 21, 2025
Summary:

Any doesn't capture tuple of different number of elements.

Test Plan: Unit tests

Differential Revision: D87598839
@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168320

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 32 Pending, 2 Unrelated Failures

As of commit f4d81d5 with merge base 2865672 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary:

Any doesn't capture tuple of different number of elements.

Test Plan: Unit tests

Differential Revision: D87598839
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@yangw-dev yangw-dev self-requested a review November 21, 2025 22:05
@yangw-dev
Copy link
Contributor

yangw-dev commented Nov 21, 2025

@pytorch merge -i

@yangw-dev
Copy link
Contributor

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-docs / build-docs-python-false, pull / linux-jammy-py3.10-gcc11 / test (docs_test, 1, 1, lf.linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 22, 2025
tuple[int] -> tuple[int,...]

1 -> more

Like shape, shape: tuple[int, ...]  # [B, Hq, M, Hkv, N, D]

Inspired by #168320

Pull Request resolved: #168892
Approved by: https://github.com/cyyever, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants