Skip to content

Conversation

@PawelSwider2000
Copy link
Contributor

@PawelSwider2000 PawelSwider2000 commented Nov 27, 2025

Change hardcoded "cuda:0" to device param to allow to running test_triton_fx_graph_with_et on different devices, especially test now passed on XPU.

Simplify skip conditions and make minor refactor.

Fixes intel/torch-xpu-ops#2040

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169181

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e873c34 with merge base 8ca51be (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 27, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: PawelSwider2000 / name: Pawel Swider (e873c34)

@PawelSwider2000
Copy link
Contributor Author

@EikanWang @guangyey @chuanqi129 Please help with review

@chuanqi129
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased pswider/test-execution-trace-xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pswider/test-execution-trace-xpu && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the pswider/test-execution-trace-xpu branch from b0d83d5 to 10a4618 Compare December 8, 2025 17:58
@guangyey guangyey marked this pull request as ready for review December 9, 2025 05:28
@guangyey guangyey added ciflow/xpu Run XPU CI tasks ciflow/trunk Trigger trunk jobs on your pull request labels Dec 9, 2025
@guangyey guangyey requested a review from jansel December 9, 2025 05:30
@PawelSwider2000 PawelSwider2000 force-pushed the pswider/test-execution-trace-xpu branch from 10a4618 to 63b45e0 Compare December 10, 2025 07:48
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks labels Dec 10, 2025
@PawelSwider2000
Copy link
Contributor Author

CI failed with unrelated, flaky tests, rebased.
@jansel please review

@PawelSwider2000
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased pswider/test-execution-trace-xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pswider/test-execution-trace-xpu && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the pswider/test-execution-trace-xpu branch from 63b45e0 to e873c34 Compare December 12, 2025 11:10
@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/xpu Run XPU CI tasks labels Dec 12, 2025
@chuanqi129 chuanqi129 added the ciflow/xpu Run XPU CI tasks label Dec 15, 2025
@PawelSwider2000
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

vishalgoyal316 pushed a commit to vishalgoyal316/pytorch that referenced this pull request Dec 17, 2025
Change hardcoded `"cuda:0"` to `device` param to allow to running `test_triton_fx_graph_with_et` on different devices, especially test now passed on XPU.

Simplify skip conditions and make minor refactor.

Fixes intel/torch-xpu-ops#2040

Pull Request resolved: pytorch#169181
Approved by: https://github.com/guangyey, https://github.com/jansel, https://github.com/EikanWang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

Status: Done

7 participants