Skip to content

[Inductor] Add deterministic mode for benchmark perf tests#178233

Closed
karthickai wants to merge 2 commits into
gh/karthickai/51/basefrom
gh/karthickai/51/head
Closed

[Inductor] Add deterministic mode for benchmark perf tests#178233
karthickai wants to merge 2 commits into
gh/karthickai/51/basefrom
gh/karthickai/51/head

Conversation

@karthickai
Copy link
Copy Markdown
Collaborator

@karthickai karthickai commented Mar 24, 2026

Stack from ghstack (oldest at bottom):

The CI perf benchmarks already run accuracy tests with deterministic mode enabled setup_determinism_for_accuracy_test(). This PR adds a --deterministic CLI flag and a deterministic_perf dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes #177269

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

@karthickai karthickai requested a review from a team as a code owner March 24, 2026 03:47
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/178233

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 4eeb928 with merge base 994d496 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

karthickai added a commit that referenced this pull request Mar 24, 2026
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. 

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes #177269 

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo

[ghstack-poisoned]
karthickai added a commit that referenced this pull request Mar 25, 2026
@karthickai karthickai requested review from eellison and jansel March 25, 2026 18:44
@karthickai
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 26, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

meta-codesync Bot pushed a commit to pytorch/benchmark that referenced this pull request Mar 26, 2026
Summary:
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes #177269

X-link: pytorch/pytorch#178233
Approved by: https://github.com/jansel

Reviewed By: georgehong

Differential Revision: D98314065

fbshipit-source-id: 0dd1fff1980b4ed48ccb18d749c46662cb68a252
Copilot AI pushed a commit that referenced this pull request Mar 27, 2026
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes #177269

Pull Request resolved: #178233
Approved by: https://github.com/jansel

Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>
AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026
…78233)

The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes pytorch#177269

Pull Request resolved: pytorch#178233
Approved by: https://github.com/jansel
pytorch-bot Bot pushed a commit that referenced this pull request Apr 2, 2026
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes #177269

Pull Request resolved: #178233
Approved by: https://github.com/jansel
nklshy-aws pushed a commit to nklshy-aws/pytorch that referenced this pull request Apr 7, 2026
…78233)

The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode.

This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.

Fixes pytorch#177269

Pull Request resolved: pytorch#178233
Approved by: https://github.com/jansel
@github-actions github-actions Bot deleted the gh/karthickai/51/head branch April 26, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants