[Inductor] Add deterministic mode for benchmark perf tests#178233
Closed
karthickai wants to merge 2 commits into
Closed
[Inductor] Add deterministic mode for benchmark perf tests#178233karthickai wants to merge 2 commits into
karthickai wants to merge 2 commits into
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/178233
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 4eeb928 with merge base 994d496 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes #177269 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
jansel
approved these changes
Mar 26, 2026
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
meta-codesync Bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Mar 26, 2026
Summary: The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes #177269 X-link: pytorch/pytorch#178233 Approved by: https://github.com/jansel Reviewed By: georgehong Differential Revision: D98314065 fbshipit-source-id: 0dd1fff1980b4ed48ccb18d749c46662cb68a252
Copilot AI
pushed a commit
that referenced
this pull request
Mar 27, 2026
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes #177269 Pull Request resolved: #178233 Approved by: https://github.com/jansel Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>
AaronWang04
pushed a commit
to AaronWang04/pytorch
that referenced
this pull request
Mar 31, 2026
…78233) The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes pytorch#177269 Pull Request resolved: pytorch#178233 Approved by: https://github.com/jansel
pytorch-bot Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes #177269 Pull Request resolved: #178233 Approved by: https://github.com/jansel
nklshy-aws
pushed a commit
to nklshy-aws/pytorch
that referenced
this pull request
Apr 7, 2026
…78233) The CI perf benchmarks already run accuracy tests with deterministic mode enabled `setup_determinism_for_accuracy_test()`. This PR adds a `--deterministic` CLI flag and a `deterministic_perf` dashboard tag variant so that performance benchmarks can also run with deterministic mode. This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants. Fixes pytorch#177269 Pull Request resolved: pytorch#178233 Approved by: https://github.com/jansel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The CI perf benchmarks already run accuracy tests with deterministic mode enabled
setup_determinism_for_accuracy_test(). This PR adds a--deterministicCLI flag and adeterministic_perfdashboard tag variant so that performance benchmarks can also run with deterministic mode.This will establish a deterministic performance baseline tracked on the inductor perf dashboard alongside existing variants.
Fixes #177269
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo