Report better errors when kernel or dispatch key are missing #18302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14572346 Differential Version: 76413229
This was referenced Mar 22, 2019
Differential Revision: D14572346 Differential Version: 76766533
This was referenced Mar 25, 2019
Closed
dzhulgakov
reviewed
Mar 26, 2019
Differential Revision: D14572346 Differential Version: 76961195
Differential Revision: D14572346 Differential Version: 77111686
This was referenced Mar 27, 2019
Differential Revision: D14572346 Differential Version: 77124221
This was referenced Mar 27, 2019
Differential Revision: D14572346 Differential Version: 77219511
Differential Revision: D14572346 Differential Version: 77235124
Differential Revision: D14572346 Differential Version: 77241457
Differential Revision: D14572346 Differential Version: 77272978
This was referenced Mar 28, 2019
Differential Revision: D14572346 Differential Version: 77289987
This was referenced Mar 29, 2019
Differential Revision: D14572346 Differential Version: 77374926
Differential Revision: D14572346 Differential Version: 77381526
Differential Revision: D14572346 Differential Version: 77424595
Differential Revision: D14572346 Differential Version: 77453782
|
This pull request has been merged in 24752eb. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#18302 These might be use cases we want to support in the future, but they don't work yet. Let's at least report an error instead of doing segfaults or worse. Reviewed By: dzhulgakov Differential Revision: D14572346 fbshipit-source-id: 49262ce131493bc887defe2978d8b22f202cd8cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #18161 New operator registration MVP 💚
:white_circle: #18162 Add functor- and function-based kernel registration API 💚
:white_circle: #18256 Check kernel against function schema in c10 op registration 💚
:white_circle: #18301 Move stuff to cpp files 💚
:black_circle: #18302 Report better errors when kernel or dispatch key are missing 💚
:white_circle: #18541 Introduce lambda-based kernel API 💚
:white_circle: #18443 Fallback kernels 💚
:white_circle: #18444 deprecated function based API 💛
:white_circle: #18542 Deprecated lambda based API 💚
:white_circle: #18547 Improve and test error messages for signature mismatches 💚
:white_circle: #18550 Improve compiler error messages of the op registration API 💚
:white_circle: #18551 Allow registering an operator schema without a kernel 💚
:white_circle: #18577 Register operators by passing arguments to RegisterOperators constructor 💛
:white_circle: #18592 [wip] Move ATen-core target one directory up 💛
:white_circle: #18593 [wip] Split function schema parser from operator 💛
:white_circle: #18594 [wip] Use function schema parser from op registration API 💛
:white_circle: #18597 [wip] Rewrite test cases with string based schema 💛
:white_circle: #18599 [wip] Use string based schema for exposing caffe2 ops 💛
:white_circle: #18600 [wip] Remove FunctionSchema based registration APIs 💛
These might be use cases we want to support in the future, but they don't work yet.
Let's at least report an error instead of doing segfaults or worse.
Differential Revision: D14572346