Skip to content

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Mar 28, 2019

No description provided.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gchanan! How/where did this surface? Anything we can do in CI?

@gchanan
Copy link
Contributor Author

gchanan commented Mar 28, 2019

@pytorchbot rebase this please.

@gchanan
Copy link
Contributor Author

gchanan commented Mar 28, 2019

@pietern it looks like it's been broken since this function was ported to C++ (5-6 months ago). We'd need a configuration to test this -- is that hard to add?

As for it being surfaced, I was trying to build without nccl because of #18359.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in d895d30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants