Skip to content

Fix c10d build without nccl. #18582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix c10d build without nccl. #18582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec4792f
Fix c10d build without nccl.
gchanan Mar 28, 2019
f80af1b
Merge remote-tracking branch 'origin/master' into HEAD
Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions torch/csrc/distributed/c10d/ddp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
#include <torch/csrc/cuda/comm.h>
#include <torch/csrc/utils/tensor_flatten.h>

#ifdef USE_C10D_NCCL
#include <torch/csrc/cuda/nccl.h>
#endif

#include <c10d/ProcessGroup.hpp>

Expand Down Expand Up @@ -129,6 +131,11 @@ std::tuple<std::shared_ptr<ProcessGroup::Work>, at::Tensor> queueReduction(
ProcessGroup& processGroup,
std::vector<std::vector<at::Tensor>>& gradsBatch,
const std::vector<int64_t>& devices) {
#ifndef USE_C10D_NCCL
if (devices.size() > 1) {
AT_ERROR("queueReduction with more than 1 device not suppported without NCCL");
}
#endif
AT_ASSERT(!gradsBatch.empty());
AT_ASSERT(!devices.empty());

Expand Down Expand Up @@ -160,7 +167,11 @@ std::tuple<std::shared_ptr<ProcessGroup::Work>, at::Tensor> queueReduction(
}

if (devices.size() > 1) {
#ifdef USE_C10D_NCCL
torch::cuda::nccl::reduce(gradsBatchCoalesced, 0);
#else
AT_ERROR("shouldn't have gotten here -- queueReduction not suppported without NCCL");
#endif
}

gradsBatchCoalesced[0] /= processGroup.getSize();
Expand Down