Remove THSTensor and SparseTensorRef#20877
Closed
li-roy wants to merge 3 commits intogh/li-roy/22/basefrom
Closed
Conversation
pytorchbot
added
oncall: jit
li-roy
changed the title
Remove THSTensor and SparseTensorRef gh-metadata: pytorch pytorch 20877 gh/li-roy/22/head
ezyang
approved these changes
May 28, 2019
zdevito
approved these changes
May 28, 2019
Remove THSTensor and SparseTensorRef gh-metadata: pytorch pytorch 20877 gh/li-roy/22/head
dzhulgakov
approved these changes
May 29, 2019
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
red diffs are my favorite :)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 29, 2019
Summary: Pull Request resolved: pytorch/pytorch#20877 ghimport-source-id: a07f53ca158f9a3dce7a25ef5a169871e98ea3ea Differential Revision: D15480353 Pulled By: li-roy fbshipit-source-id: 1152dbc4df827ded3be1a57f007a6b7de12f567f
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We don't need these anymore because THS doesn't exist anymore. Removing so we don't have to support SparseTensorRef in c10 dispatcher, and so we can stop blacklisting it in jit registry.
Differential Revision: D15480353