Restructure comparison ops so as to better support XLA dispatch #29591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailzhang
approved these changes
Nov 11, 2019
Per @ailzhang's suggestion, this PR changes the implementation of binary comparison and logical ops to those of unary ops in UnaryOps.cpp. The reason is that the call should eventually go through at::op_out (e.g., at::logical_xor_out). The check for Boolean output tensor is also removed, because: - This check should only apply to _out functions but not on other variants. However, other variants must go through the _out variant eventually. - It does not have a clear motivation and seems unnecessary.
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
All tests passed, landing. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 13, 2019
Summary: Per ailzhang's suggestion in pytorch/pytorch#28162 (comment), this PR changes the implementation of binary comparison and logical ops to those of unary ops in UnaryOps.cpp. The reason is that the call should eventually go through at::op_out (e.g., at::logical_xor_out). The check for Boolean output tensor is also removed, because: - This check should only apply to _out functions but not on other variants. However, other variants must go through the _out variant eventually. - It does not have a clear motivation and seems unnecessary. Pull Request resolved: pytorch/pytorch#29591 Differential Revision: D18460113 Pulled By: ailzhang fbshipit-source-id: 58d501e59335186b3b8cc7d80ee9eed74efeeac8
xuhdev
added a commit
to xuhdev/pytorch-xla
that referenced
this pull request
Nov 13, 2019
Emancipated by pytorch/pytorch#29591
|
Thanks! |
xuhdev
added a commit
to xuhdev/pytorch-xla
that referenced
this pull request
Nov 13, 2019
Emancipated by pytorch/pytorch#29591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @ailzhang's suggestion in #28162 (comment), this PR changes the implementation of binary comparison and logical ops
to those of unary ops in UnaryOps.cpp. The reason is that the call should eventually go through
at::op_out (e.g., at::logical_xor_out).
The check for Boolean output tensor is also removed, because:
must go through the _out variant eventually.