Enable test_logical_xor #1350
Closed
Enable test_logical_xor #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailzhang
approved these changes
Nov 13, 2019
Emancipated by pytorch/pytorch#29591
xuhdev
force-pushed
the
remove-logical-xor
branch
from
f5760e4 to
73015e1
Compare
|
@ailzhang Done! |
|
Aha sadly this test still fails at |
|
Maybe we can wait until pytorch/pytorch#28162 is merged? There the test code has specifically skipped XLA for |
SG! Let me put a label on this so that we come back to it later :D |
|
Closing now, as it should give way to #1428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emancipated by pytorch/pytorch#29591