Skip to content

Conversation

@suo
Copy link
Member

@suo suo commented Dec 6, 2019

Stack from ghstack:

Fixes all outstanding lints and actually installs a properly configured
flake8

Differential Revision: D18862825

Fixes all outstanding lints and actually installs a properly configured
flake8
@suo suo requested a review from apaszke as a code owner December 6, 2019 19:15
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 6, 2019
@suo suo requested a review from ezyang December 6, 2019 19:15
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small questions.
Not sure if the fbgemm is expected though.

Fixes all outstanding lints and actually installs a properly configured
flake8
Fixes all outstanding lints and actually installs a properly configured
flake8
Fixes all outstanding lints and actually installs a properly configured
flake8

Differential Revision: [D18862825](https://our.internmc.facebook.com/intern/diff/D18862825)
suo added a commit that referenced this pull request Dec 6, 2019
Fixes all outstanding lints and actually installs a properly configured
flake8

ghstack-source-id: 6610357
Pull Request resolved: #30892
@kostmo
Copy link
Member

kostmo commented Dec 7, 2019

CircleCI build failures summary

As of commit c595231:

  • 1/1 broken upstream at merge base 26c5146 (see grid view)
    • You may want to rebase on the viable/strict branch (see its recency history):
      • If your commit is older than viable/strict:
        git fetch viable/strict
        git rebase viable/strict
        
      • If your commit is newer than viable/strict, you can try basing on an older, stable commit:
        git fetch viable/strict
        git rebase --onto viable/strict $(git merge-base origin/master HEAD)
        
  • 0/1 failures introduced in this PR

Detailed failure analysis (WIP)

Here are the reasons each build failed:

1 failure recognized by patterns:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_build

Step: Build

Dec 06 21:34:04 caused by: Connection refused (os error 111)

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

@suo merged this pull request in 62b1072.

@facebook-github-bot facebook-github-bot deleted the gh/suo/237/head branch December 10, 2019 15:20
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Pull Request resolved: pytorch#30892

Fixes all outstanding lints and actually installs a properly configured
flake8

Test Plan: Imported from OSS

Differential Revision: D18862825

Pulled By: suo

fbshipit-source-id: 08e9083338a7309272e17bb803feaa42e348aa85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants