-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[lint] Actually make flake8 do something #30892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes all outstanding lints and actually installs a properly configured flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small questions.
Not sure if the fbgemm is expected though.
Fixes all outstanding lints and actually installs a properly configured flake8
Fixes all outstanding lints and actually installs a properly configured flake8
Fixes all outstanding lints and actually installs a properly configured flake8 Differential Revision: [D18862825](https://our.internmc.facebook.com/intern/diff/D18862825)
CircleCI build failures summaryAs of commit c595231:
Detailed failure analysis (WIP)Here are the reasons each build failed: 1 failure recognized by patterns:
|
Summary: Pull Request resolved: pytorch#30892 Fixes all outstanding lints and actually installs a properly configured flake8 Test Plan: Imported from OSS Differential Revision: D18862825 Pulled By: suo fbshipit-source-id: 08e9083338a7309272e17bb803feaa42e348aa85
Stack from ghstack:
Fixes all outstanding lints and actually installs a properly configured
flake8
Differential Revision: D18862825