Fix case when hash returns negative integer #32882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Update tensorboard binary and unit tests to python 3 Test Plan: ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_test ``` ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_exporter_test ``` Reviewed By: sanekmelnikov Differential Revision: D19670873 fbshipit-source-id: 803ea6809e5c80d9dee1f611fe15cf8f6207aac1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19670873 |
sanekmelnikov
approved these changes
Jan 31, 2020
J0Nreynolds
changed the title
Contributor
|
This pull request has been merged in 14c15eb. |
1 similar comment
Contributor
|
This pull request has been merged in 14c15eb. |
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: Pull Request resolved: pytorch#32882 Update tensorboard binary and unit tests to python 3 Test Plan: ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_test ``` ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_exporter_test ``` Reviewed By: sanekmelnikov Differential Revision: D19670873 fbshipit-source-id: f5eb65ccbb4ecfdc801b9fa05a60d4c5c29dc428
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#32882 Update tensorboard binary and unit tests to python 3 Test Plan: ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_test ``` ``` > buck test //caffe2/caffe2/contrib/tensorboard:tensorboard_exporter_test ``` Reviewed By: sanekmelnikov Differential Revision: D19670873 fbshipit-source-id: f5eb65ccbb4ecfdc801b9fa05a60d4c5c29dc428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update tensorboard binary and unit tests to python 3
Test Plan:
Reviewed By: sanekmelnikov
Differential Revision: D19670873