Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Feb 13, 2020

Stack from ghstack:

Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: D20354878

@jerryzh168 jerryzh168 requested a review from apaszke as a code owner February 13, 2020 03:23
This was referenced Feb 13, 2020
jerryzh168 added a commit that referenced this pull request Feb 13, 2020
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

ghstack-source-id: 76fbf6b
Pull Request resolved: #33279
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 13, 2020
@dr-ci
Copy link

dr-ci bot commented Feb 13, 2020

💊 CircleCI build failures summary and remediations

As of commit 48f6a27 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details)

Mar 12 11:13:24 RuntimeError: test_jit failed!
Mar 12 11:13:23 Ran 2429 tests in 134.029s 
Mar 12 11:13:23  
Mar 12 11:13:23 FAILED (errors=1, skipped=70, expected failures=1) 
Mar 12 11:13:23  
Mar 12 11:13:23 Generating XML reports... 
Mar 12 11:13:24 Traceback (most recent call last): 
Mar 12 11:13:24   File "test/run_test.py", line 674, in <module> 
Mar 12 11:13:24     main() 
Mar 12 11:13:24   File "test/run_test.py", line 667, in main 
Mar 12 11:13:24     raise RuntimeError(message) 
Mar 12 11:13:24 RuntimeError: test_jit failed! 
Mar 12 11:13:24 + cleanup 
Mar 12 11:13:24 + retcode=1 
Mar 12 11:13:24 + set +x 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 206 times.

jerryzh168 added a commit that referenced this pull request Feb 14, 2020
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

ghstack-source-id: f930505
Pull Request resolved: #33279
jerryzh168 added a commit that referenced this pull request Feb 14, 2020
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5ad85ce
Pull Request resolved: #33279
jerryzh168 added a commit that referenced this pull request Feb 18, 2020
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5c5bcbf
Pull Request resolved: #33279
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
FileCheck().check_not("aten::conv2d") \
.check_not("aten::relu") \
.check("quantized::conv2d_relu") \
.run(m.graph_for(data))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other checks that one can do: i.e check if there is a single inlined graph and that all weight tensors are constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the functionality of freeze? doesn't feel like that's something we should be testing here

Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: [D20354878](https://our.internmc.facebook.com/intern/diff/D20354878)

[ghstack-poisoned]
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: [D20354878](https://our.internmc.facebook.com/intern/diff/D20354878)

[ghstack-poisoned]
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: [D20354878](https://our.internmc.facebook.com/intern/diff/D20354878)

[ghstack-poisoned]
Summary:
att

Test Plan:
python test/test_jit.py

Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: [D20354878](https://our.internmc.facebook.com/intern/diff/D20354878)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Mar 13, 2020
Summary:
Pull Request resolved: #33279

att

Test Plan:
python test/test_jit.py

Imported from OSS

Differential Revision: D20354878

fbshipit-source-id: 2b19797d4b3fd96918164a58bfbd768211ad6c6d
ghstack-source-id: 953d048
jerryzh168 added a commit that referenced this pull request Mar 13, 2020
Summary:
att

Test Plan:
python test/test_jit.py

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Mar 13, 2020
…n pattern (#33279)"

Summary:
att

Test Plan:
python test/test_jit.py

Differential Revision: [D20449667](https://our.internmc.facebook.com/intern/diff/D20449667)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Mar 13, 2020
Summary:
att

Test Plan:
python test/test_jit.py

ghstack-source-id: 870eb8c
Pull Request resolved: #34744
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0ff4d37.

facebook-github-bot pushed a commit that referenced this pull request Mar 14, 2020
…33279) (#34744)

Summary:
Pull Request resolved: #34744

att

Test Plan: python test/test_jit.py

Differential Revision: D20449667

Pulled By: jerryzh168

fbshipit-source-id: 01bbc26604fac421dcaacaf4fa1b57731f1f08b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants