Skip to content

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Mar 11, 2020

Stack from ghstack:

Summary:
This is only for Tensor - Tensor add, we'll need to support Tensor - Scalar add in a different way, since that does not need observer
Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D20519607

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner March 11, 2020 02:27
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 11, 2020
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Mar 11, 2020

💊 CircleCI build failures summary and remediations

As of commit 3657a7b (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base a00e12e since Mar 23

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 134 times.

Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This adds support to Tensor add, we don't support scalar add right now, will support that later

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
Summary:
This is only for Tensor - Tensor add, we'll need to support Tensor - Scalar add in a different way, since that does not need observer
Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20519607](https://our.internmc.facebook.com/intern/diff/D20519607)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in eff68bc.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/247/head branch March 27, 2020 14:16
okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020
Summary:

Test Plan:
python test/test_jit.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3794351
Pull Request resolved: pytorch/pytorch#34572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants