Skip to content

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented May 29, 2020

Stack from ghstack:

We don't actually cast between these complex representations, but the prior implementation would indicate that we needed to dynamic_cast,
because we didn't have mappings for std::complex or thrust::complex.

This PR makes it so they all map to the same dtype.

Note that this has no functional change as all the use sites have already been changed to take this into account.

Differential Revision: D21789694

We don't actually cast between these complex representations, but the prior implementation would indicate that we needed to dynamic_cast,
because we didn't have mappings for std::complex or thrust::complex.

This PR makes it so they all map to the same dtype.

Note that this has no functional change as all the use sites have already been changed to take this into account.

[ghstack-poisoned]
gchanan added a commit that referenced this pull request May 29, 2020
We don't actually cast between these complex representations, but the prior implementation would indicate that we needed to dynamic_cast,
because we didn't have mappings for std::complex or thrust::complex.

This PR makes it so they all map to the same dtype.

Note that this has no functional change as all the use sites have already been changed to take this into account.

ghstack-source-id: fcc12c0
Pull Request resolved: #39255
@dr-ci
Copy link

dr-ci bot commented May 29, 2020

💊 CI failures summary and remediations

As of commit 2d85012 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

gchanan added 2 commits May 29, 2020 11:54
We don't actually cast between these complex representations, but the prior implementation would indicate that we needed to dynamic_cast,
because we didn't have mappings for std::complex or thrust::complex.

This PR makes it so they all map to the same dtype.

Note that this has no functional change as all the use sites have already been changed to take this into account.

Differential Revision: [D21789694](https://our.internmc.facebook.com/intern/diff/D21789694)

[ghstack-poisoned]
We don't actually cast between these complex representations, but the prior implementation would indicate that we needed to dynamic_cast,
because we didn't have mappings for std::complex or thrust::complex.

This PR makes it so they all map to the same dtype.

Note that this has no functional change as all the use sites have already been changed to take this into account.

Differential Revision: [D21789694](https://our.internmc.facebook.com/intern/diff/D21789694)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in 9b05b1b.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in 9b05b1b.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/291/head branch June 5, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants