Skip to content

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented May 29, 2020

Stack from ghstack:

Differential Revision: D21790288

@gchanan
Copy link
Contributor Author

gchanan commented May 29, 2020

This is the same as #39071, but restacked and including the suggested changes.

…> by using some decltype tricks."

Differential Revision: [D21790288](https://our.internmc.facebook.com/intern/diff/D21790288)

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented May 29, 2020

💊 CI failures summary and remediations

As of commit 2d7aea0 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

…> by using some decltype tricks."

Differential Revision: [D21790288](https://our.internmc.facebook.com/intern/diff/D21790288)

[ghstack-poisoned]
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in ddf6d49.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/293/head branch June 5, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants