Skip to content

[DO NOT REVIEW] Trying #40358 DDP tests on master without grad layout diffs #40290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

[DO NOT REVIEW] Trying #40358 DDP tests on master without grad layout diffs #40290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e9be646
Try DDP tests on clean master
definitelynotmcarilli Jun 19, 2020
d542025
hung with syncs, retrying without syncs
definitelynotmcarilli Jun 19, 2020
a7b813f
see if introducing syncs to other tests also causes hangs
definitelynotmcarilli Jun 19, 2020
c25ae6f
see if skipping the evil test fixes everything
definitelynotmcarilli Jun 19, 2020
cbe64ba
maybe syncs were making extra contexts (slow but not hanging)
definitelynotmcarilli Jun 20, 2020
b77980d
pass rank from test
definitelynotmcarilli Jun 20, 2020
8dbb0ee
merging in master
definitelynotmcarilli Jun 21, 2020
269ef13
only contiguous params
definitelynotmcarilli Jun 21, 2020
78b2668
remove syncs in distributed.py
definitelynotmcarilli Jun 21, 2020
9fd0c7a
add timing info
definitelynotmcarilli Jun 21, 2020
5bb406a
sync DDP on module device after replicate
definitelynotmcarilli Jun 22, 2020
c11abdf
maybe isolate hanging device
definitelynotmcarilli Jun 22, 2020
a15fe49
Syncs after reducer also
definitelynotmcarilli Jun 22, 2020
6c205eb
only sync if devs are there
definitelynotmcarilli Jun 22, 2020
09e61a7
maybe sync after optimizers??
definitelynotmcarilli Jun 22, 2020
b21cfa1
Move opt before DDP
definitelynotmcarilli Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading