-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Register cummaxmin_backward, cumprod_backward as operators #44410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` [ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` [ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f2fcef3 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/zou3519/301/base #44410 +/- ##
====================================================
Coverage 67.99% 67.99%
====================================================
Files 382 382
Lines 49380 49380
====================================================
Hits 33577 33577
Misses 15803 15803 Continue to review full report at Codecov.
|
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503) [ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503) [ghstack-poisoned]
Summary: Pull Request resolved: #44410 See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Reviewed By: mrshenli Differential Revision: D23605503 Pulled By: zou3519 fbshipit-source-id: f9c5b595e62d2d6e71f26580ba96df15cc9de4f7
Summary: Pull Request resolved: #44410 See #44052 for context. One of the cumprod_backward overloads was unused so I just deleted it. Test Plan: - `pytest test/test_autograd.py -v` Reviewed By: mrshenli Differential Revision: D23605503 Pulled By: zou3519 fbshipit-source-id: f9c5b595e62d2d6e71f26580ba96df15cc9de4f7
Stack from ghstack:
See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.
Test Plan:
pytest test/test_autograd.py -vDifferential Revision: D23605503