Skip to content

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 9, 2020

Stack from ghstack:

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:

  • pytest test/test_autograd.py -v

Differential Revision: D23605503

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

[ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

[ghstack-poisoned]
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

[ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503)

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Sep 9, 2020

💊 CI failures summary and remediations

As of commit f2fcef3 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 9, 2020
See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

ghstack-source-id: 53afb07
Pull Request resolved: #44410
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #44410 into gh/zou3519/301/base will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           gh/zou3519/301/base   #44410   +/-   ##
====================================================
  Coverage                67.99%   67.99%           
====================================================
  Files                      382      382           
  Lines                    49380    49380           
====================================================
  Hits                     33577    33577           
  Misses                   15803    15803           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e83a89...f2fcef3. Read the comment docs.

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503)

[ghstack-poisoned]
See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan:
- `pytest test/test_autograd.py -v`

Differential Revision: [D23605503](https://our.internmc.facebook.com/intern/diff/D23605503)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 7ff7e6c.

bitfort pushed a commit that referenced this pull request Sep 11, 2020
Summary:
Pull Request resolved: #44410

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan: - `pytest test/test_autograd.py -v`

Reviewed By: mrshenli

Differential Revision: D23605503

Pulled By: zou3519

fbshipit-source-id: f9c5b595e62d2d6e71f26580ba96df15cc9de4f7
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/301/head branch September 14, 2020 14:17
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
Summary:
Pull Request resolved: #44410

See #44052 for context. One of the cumprod_backward overloads was unused
so I just deleted it.

Test Plan: - `pytest test/test_autograd.py -v`

Reviewed By: mrshenli

Differential Revision: D23605503

Pulled By: zou3519

fbshipit-source-id: f9c5b595e62d2d6e71f26580ba96df15cc9de4f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants