[ONNX] Bool inputs to index_put updated symbolic #46866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
shubhambhokare1
changed the title
Codecov Report
@@ Coverage Diff @@
## master #46866 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 1809 1809
Lines 190035 190017 -18
=======================================
- Hits 153540 153526 -14
+ Misses 36495 36491 -4 |
💊 CI failures summary and remediationsAs of commit b0b471e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedcodecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 24 times. |
mrshenli
added
module: onnx
KsenijaS
reviewed
Oct 28, 2020
BowenBao
reviewed
Oct 28, 2020
added 4 commits
November 4, 2020 09:51
…kare/bool-input-scripting
…kare/bool-input-scripting
BowenBao
reviewed
Nov 6, 2020
added 8 commits
November 6, 2020 12:14
…kare/bool-input-scripting
…ubhambhokare1/pytorch into sbhokare/bool-input-scripting
…kare/bool-input-scripting
bzinodev
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases with bool inputs to index_put nodes were handled for tracing purposes. This PR adds support for similar situations in scripting