Fix type promotion + broadcasting bug #47288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the types don't match" This reverts commit b3eb0c8. [ghstack-poisoned]
bdhirsh
changed the title
Codecov Report
@@ Coverage Diff @@
## gh/bdhirsh/31/base #47288 +/- ##
======================================================
- Coverage 60.81% 60.81% -0.01%
======================================================
Files 2749 2749
Lines 254098 254108 +10
======================================================
+ Hits 154537 154539 +2
- Misses 99561 99569 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the description in #46399 for all of the details.
That PR broke master due to a linting error and had to be reverted. I generated this PR by reverting the revert, and updating
test/test_torch.pyto fix the lint errors.Stack from ghstack:
This reverts commit b3eb0c8.
Differential Revision: D24706531